ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-05-12 01:10:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename check_err() parameter

Browse Source
This commit is contained in:
Po Yen Chen
2024-04-09 14:02:13 +00:00
parent b71b9d2159
commit 93f608123d
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
example/ck_tile/01_fmha/fmha_fwd.cpp
View File

@@ -117,15 +117,15 @@ auto get_elimit<ck_tile::fp8_t>(int init_method)
{
if(init_method == 0)
{
unsigned rounding_error = 0;
double atol = 2e-3;
return ck_tile::make_tuple(rounding_error, atol);
unsigned max_rounding_error_distance = 0;
double atol = 2e-3;
return ck_tile::make_tuple(max_rounding_error_distance, atol);
}
else
{
unsigned rounding_error = 1;
double atol = 0.0625;
return ck_tile::make_tuple(rounding_error, atol);
unsigned max_rounding_error_distance = 1;
double atol = 0.0625;
return ck_tile::make_tuple(max_rounding_error_distance, atol);
}
}

12
include/ck_tile/host/check_err.hpp
View File

@@ -272,10 +272,10 @@ std::enable_if_t<(std::is_same_v<ranges::range_value_t<Range>, ranges::range_val
bool>
CK_TILE_HOST check_err(const Range& out,
const RefRange& ref,
const std::string& msg = "Error: Incorrect results!",
unsigned rounding_error = 1,
double atol = 1e-1,
bool allow_infinity_ref = false)
const std::string& msg = "Error: Incorrect results!",
unsigned max_rounding_error_distance = 1,
double atol = 1e-1,
bool allow_infinity_ref = false)
{
if(out.size() != ref.size())
{
@@ -291,7 +291,7 @@ std::enable_if_t<(std::is_same_v<ranges::range_value_t<Range>, ranges::range_val
return either_not_finite && !(allow_infinity_ref && both_infinite_and_same);
};
static const auto get_rounding_error = [](fp8_t o, fp8_t r) -> unsigned {
static const auto get_rounding_error_distance = [](fp8_t o, fp8_t r) -> unsigned {
static const auto get_sign_bit = [](fp8_t v) -> bool {
return 0x80 & bit_cast<uint8_t>(v);
};
@@ -318,7 +318,7 @@ std::enable_if_t<(std::is_same_v<ranges::range_value_t<Range>, ranges::range_val
const double r_fp64 = type_convert<float>(r_fp8);
err = std::abs(o_fp64 - r_fp64);
if(!(less_equal<double>{}(err, atol) ||
get_rounding_error(o_fp8, r_fp8) <= rounding_error) ||
get_rounding_error_distance(o_fp8, r_fp8) <= max_rounding_error_distance) ||
is_infinity_error(o_fp64, r_fp64))
{
max_err = err > max_err ? err : max_err;