use ThreadwiseTensorSliceTransfer_v2 for d0/1 copy

This commit is contained in:
Jin Zhou
2025-09-04 10:04:04 +00:00
parent 62fb5184d7
commit a67a4a06c1
2 changed files with 105 additions and 198 deletions

View File

@@ -1,131 +0,0 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2018-2022, Advanced Micro Devices, Inc. All rights reserved.
#pragma once
#include "ck/utility/common_header.hpp"
#include "ck/tensor_description/tensor_descriptor.hpp"
#include "ck/tensor_description/tensor_descriptor_helper.hpp"
#include "ck/tensor_description/cluster_descriptor.hpp"
#include "ck/tensor_operation/gpu/thread/threadwise_tensor_slice_transfer.hpp"
namespace ck {
template <typename ThreadGroup,
typename SliceLengths,
typename ThreadClusterLengths,
typename ThreadClusterArrangeOrder,
typename SrcData,
typename DstData,
typename SrcDesc,
typename DstDesc,
typename DimAccessOrder,
index_t VectorDim,
index_t ScalarPerVector,
bool ThreadTransferSrcResetCoordinateAfterRun>
struct ThreadGroupTensorSliceTransfer_v2
{
static constexpr index_t nDim = remove_reference_t<SrcDesc>::GetNumOfDimension();
static constexpr auto thread_slice_lengths = SliceLengths{} / ThreadClusterLengths{};
using Index = MultiIndex<nDim>;
__device__ constexpr ThreadGroupTensorSliceTransfer_v2(
const SrcDesc& src_desc,
const Index& src_block_slice_origin
)
: threadwise_transfer_(src_desc,
make_zero_multi_index<nDim>())
{
static_assert(nDim == remove_cvref_t<SrcDesc>::GetNumOfDimension() &&
nDim == ThreadClusterLengths::Size() &&
nDim == ThreadClusterArrangeOrder::Size() &&
nDim == DimAccessOrder::Size(),
"wrong! nDim not consistent");
static_assert(
is_same<SliceLengths, decltype(thread_slice_lengths * ThreadClusterLengths{})>{},
"wrong! threads should be mapped to cover entire slicing window");
static_assert(ThreadGroup::GetNumOfThread() >= thread_cluster_desc_.GetElementSize(),
"wrong! ThreadGroup::GetNumOfThread() too small");
if(ThreadGroup::GetNumOfThread() == thread_cluster_desc_.GetElementSize() or
ThreadGroup::GetThreadId() < thread_cluster_desc_.GetElementSize())
{
const auto thread_cluster_idx = thread_cluster_desc_.CalculateBottomIndex(
make_multi_index(ThreadGroup::GetThreadId()));
const auto thread_data_idx_begin = thread_cluster_idx * thread_slice_lengths;
threadwise_transfer_.SetSrcSliceOrigin(src_desc,
src_block_slice_origin + thread_data_idx_begin);
}
}
template <typename SrcBuffer, typename DstBuffer, typename DstSliceOriginIdx>
__device__ void Run(const SrcDesc& src_desc,
const SrcBuffer& src_buf,
const DstDesc& dst_desc,
const DstSliceOriginIdx&,
DstBuffer& dst_buf)
{
if(ThreadGroup::GetNumOfThread() == thread_cluster_desc_.GetElementSize() or
ThreadGroup::GetThreadId() < thread_cluster_desc_.GetElementSize())
{
threadwise_transfer_.template Run<SrcBuffer, DstBuffer, DstSliceOriginIdx>(
src_desc, src_buf, dst_desc, DstSliceOriginIdx{}, dst_buf);
}
}
__device__ void MoveSrcSliceWindow(const SrcDesc& src_desc, const Index& step)
{
if(ThreadGroup::GetNumOfThread() == thread_cluster_desc_.GetElementSize() or
ThreadGroup::GetThreadId() < thread_cluster_desc_.GetElementSize())
{
threadwise_transfer_.MoveSrcSliceWindow(src_desc, step);
}
}
__device__ void SetSrcSliceOrigin(const SrcDesc& src_desc, const Index& src_block_slice_origin)
{
if(ThreadGroup::GetNumOfThread() == thread_cluster_desc_.GetElementSize() or
ThreadGroup::GetThreadId() < thread_cluster_desc_.GetElementSize())
{
const auto thread_cluster_idx = thread_cluster_desc_.CalculateBottomIndex(
make_multi_index(ThreadGroup::GetThreadId()));
const auto thread_data_idx_begin = thread_cluster_idx * thread_slice_lengths;
threadwise_transfer_.SetSrcSliceOrigin(src_desc,
src_block_slice_origin + thread_data_idx_begin);
}
}
private:
static constexpr auto thread_cluster_desc_ =
make_cluster_descriptor(ThreadClusterLengths{}, ThreadClusterArrangeOrder{});
using ThreadwiseTransfer =
ThreadwiseTensorSliceTransfer_v2<SrcData,
DstData,
SrcDesc,
DstDesc,
decltype(thread_slice_lengths),
DimAccessOrder,
VectorDim,
ScalarPerVector,
1,
ThreadTransferSrcResetCoordinateAfterRun>;
ThreadwiseTransfer threadwise_transfer_;
};
} // namespace ck

View File

@@ -16,7 +16,6 @@
#include "ck/tensor_operation/gpu/block/thread_group_tensor_slice_transfer_v7r3.hpp"
#include "ck/tensor_operation/gpu/block/thread_group_tensor_slice_transfer_v6r4.hpp"
#include "ck/tensor_operation/gpu/block/thread_group_tensor_slice_transfer_v2.hpp"
#include "ck/utility/ignore.hpp"
#define DEBUG_LOG 0
@@ -168,6 +167,12 @@ struct GridwiseGemmMultiD_xdl_cshuffle_v3_b_preshuffle
static constexpr auto BlockSizeNumber = Number<BlockSize>{};
static constexpr index_t NumDTensor = DsDataType::Size();
static constexpr auto DsBufferTransferScalarPerVectors =
generate_tuple(
[](auto i) {
return CDEShuffleBlockTransferScalarPerVectors{}[I1 + i];
},
Number<NumDTensor>{});
static constexpr auto lcm_AK1_BK1 = math::lcm(AK1Number, BK1Number);
static constexpr bool is_single_rate_mfma =
@@ -575,6 +580,36 @@ struct GridwiseGemmMultiD_xdl_cshuffle_v3_b_preshuffle
Number<NumDTensor>{});
}
template <typename CShullfeThreadSliceLengths>
__device__ static constexpr auto MakeDsBufferDescriptor(
const CShullfeThreadSliceLengths&)
{
constexpr auto slice_lenghts = CShullfeThreadSliceLengths{};
return generate_tuple(
[&](auto i) {
using DLayout = remove_cvref_t<tuple_element_t<i.value, DsLayout>>;
if constexpr(is_same<tensor_layout::gemm::RowMajor, DLayout>::value)
{
return make_naive_tensor_descriptor_packed(
make_tuple(I1,
Number<slice_lenghts[I3] / DsBufferTransferScalarPerVectors[i]>{},
I1,
Number<slice_lenghts[I3]>{}
));
}
else if constexpr(is_same<tensor_layout::gemm::ColumnMajor, DLayout>::value)
{
return make_naive_tensor_descriptor_packed(
make_tuple(I1,
Number<BlockSize / slice_lenghts[I1]>{},
I1,
I1));
}
},
Number<NumDTensor>{});
}
using DsGridDesc_M_N = remove_cvref_t<decltype(MakeDsGridDescriptor_M_N(0, 0, 0, 0, {}))>;
struct Problem
@@ -2177,85 +2212,88 @@ struct GridwiseGemmMultiD_xdl_cshuffle_v3_b_preshuffle
/////////////// ds
constexpr index_t MWave = MPerBlock / (MXdlPerWave * MPerXdl);
auto ds_buffer_lengths = make_tuple(
make_tuple(I1, I1, I1, I8), // d0
make_tuple(I1, I2, I1, I1)); // d1
const auto ds_buffer_desc =
generate_tuple(
[&](auto i) {
return make_naive_tensor_descriptor_packed(ds_buffer_lengths[i]);
},
Number<NumDTensor>{});
constexpr auto CShullfeThreadSliceLengths = Sequence<1,
CShuffleMXdlPerWavePerShuffle * MWave * MPerXdl,
1,
CShuffleNXdlPerWavePerShuffle * NWave * NPerXdl>{}
/
CShuffleBlockTransferClusterLengths_MBlock_MPerBlock_NBlock_NPerBlock{};
const auto ds_buffer_desc = MakeDsBufferDescriptor(CShullfeThreadSliceLengths);
auto d0_thread_buf = make_static_buffer<AddressSpaceEnum::Vgpr, remove_cvref_t<decltype(DsDataType{}[I0])>>(
ds_buffer_desc[I0].GetElementSpaceSize()
Number<8>{}
);
auto d1_thread_buf = make_static_buffer<AddressSpaceEnum::Vgpr, remove_cvref_t<decltype(DsDataType{}[I1])>>(
Number<16>{}//ds_buffer_desc[I1].GetElementSpaceSize()
Number<16>{}// ds_buffer_desc[I1].GetElementSpaceSize() * Number<cshullfe_thread_slice_lengths[I3]>{}
);
// tuple of starting index of Ds blockwise copy
const auto idx_ds_block_begin =
generate_tuple(
[&](auto) {
return make_multi_index(block_work_idx[I0], 0, block_work_idx[I1], 0);
},
Number<NumDTensor>{});
const auto DsShuffleBlockTransferScalarPerVectors =
generate_tuple(
[&](auto i) {
return CDEShuffleBlockTransferScalarPerVectors{}[I1 + i];
},
Number<NumDTensor>{});
static_assert(ds_grid_desc_mblock_mperblock_nblock_nperblock[I0].GetLength(Number<1>{})==64);
static_assert(ds_grid_desc_mblock_mperblock_nblock_nperblock[I0].GetLength(Number<3>{})==64);
static_assert(ds_grid_desc_mblock_mperblock_nblock_nperblock[I1].GetLength(Number<1>{})==64);
static_assert(ds_grid_desc_mblock_mperblock_nblock_nperblock[I1].GetLength(Number<3>{})==64);
auto d0_block_copy_to_vgpr = ThreadGroupTensorSliceTransfer_v2<
ThisThreadBlock,
Sequence<1,
CShuffleMXdlPerWavePerShuffle * MWave * MPerXdl,
1,
CShuffleNXdlPerWavePerShuffle * NWave * NPerXdl>, // BlockSliceLengths,
CShuffleBlockTransferClusterLengths_MBlock_MPerBlock_NBlock_NPerBlock,
Sequence<0, 1, 2, 3>, // ThreadClusterArrangeOrder,
//static_assert(ds_grid_desc_m_n[I0].GetLength(Number<1>{}) == 64);
// static_assert(ds_grid_desc_mblock_mperblock_nblock_nperblock[I0].GetElementSpaceSize()==0);
#if 0
if (blockIdx.x == 0 && threadIdx.x == 0)
{
printf("### %ld %ld\n", ds_grid_desc_mblock_mperblock_nblock_nperblock[I0].GetElementSpaceSize(),
ds_grid_desc_mblock_mperblock_nblock_nperblock[I1].GetElementSpaceSize());
}
#endif
using D0BufferTransfer = ThreadwiseTensorSliceTransfer_v2<
remove_cvref_t<decltype(DsDataType{}[I0])>, // SrcData
remove_cvref_t<decltype(DsDataType{}[I0])>, // DstData
decltype(ds_grid_desc_mblock_mperblock_nblock_nperblock[I0]), // SrcDesc
remove_cvref_t<decltype(ds_buffer_desc[I0])>, // DstDesc
Sequence<0, 1, 2, 3>, // dimAccessOrder,
3, // vectorDim
DsShuffleBlockTransferScalarPerVectors[I0],
false>{
ds_grid_desc_mblock_mperblock_nblock_nperblock[I0],
idx_ds_block_begin[I0]
};
auto d1_block_copy_to_vgpr = ThreadGroupTensorSliceTransfer_v2<
ThisThreadBlock,
Sequence<1,
CShuffleMXdlPerWavePerShuffle * MWave * MPerXdl,
1,
CShuffleNXdlPerWavePerShuffle * NWave * NPerXdl>, // BlockSliceLengths,
CShuffleBlockTransferClusterLengths_MBlock_MPerBlock_NBlock_NPerBlock,
Sequence<0, 1, 2, 3>, // ThreadClusterArrangeOrder,
remove_cvref_t<decltype(ds_buffer_desc[I0])>, // DstDesc
decltype(CShullfeThreadSliceLengths), // SliceLengths
Sequence<0, 1, 2, 3>, // DimAccessOrder,
3, // SrcVectorDim
DsBufferTransferScalarPerVectors[I0], // SrcScalarPerVector
1, // SrcScalarStrideInVector
false>;
#if 0
using D0Layout = remove_cvref_t<tuple_element_t<I0, DsLayout>>;
if constexpr(is_same<tensor_layout::gemm::RowMajor, D0Layout>::value)
{
#endif
auto d0_block_copy_to_vgpr = D0BufferTransfer(
ds_grid_desc_mblock_mperblock_nblock_nperblock[I0],
make_multi_index(block_m_id,
0,
block_n_id,
get_thread_local_1d_id() * CShullfeThreadSliceLengths[I3] % NPerBlock));
#if 0
}
else if constexpr(is_same<tensor_layout::gemm::ColumnMajor, D0Layout>::value)
{
static_assert(0);
auto d0_block_copy_to_vgpr = D0BufferTransfer(
ds_grid_desc_mblock_mperblock_nblock_nperblock[I0],
make_multi_index(block_m_id,
get_thread_local_1d_id() * 8 / 64,
block_n_id,
0));
}
#endif
auto d1_block_copy_to_vgpr = ThreadwiseTensorSliceTransfer_v2<
remove_cvref_t<decltype(DsDataType{}[I1])>, // SrcData
remove_cvref_t<decltype(DsDataType{}[I1])>, // DstData
decltype(ds_grid_desc_mblock_mperblock_nblock_nperblock[I1]), // SrcDesc
remove_cvref_t<decltype(ds_buffer_desc[I1])>, // DstDesc
Sequence<0, 1, 2, 3>, // dimAccessOrder,
3, // vectorDim
DsShuffleBlockTransferScalarPerVectors[I1],
false>{
ds_grid_desc_mblock_mperblock_nblock_nperblock[I1], // 1, 64, 1, 1
idx_ds_block_begin[I1]
};
remove_cvref_t<decltype(ds_buffer_desc[I1])>, // DstDesc
decltype(CShullfeThreadSliceLengths), // SliceLengths
Sequence<0, 1, 2, 3>, // DimAccessOrder,
3, // SrcVectorDim
DsBufferTransferScalarPerVectors[I1], // SrcScalarPerVector
1, // SrcScalarStrideInVector
false>(
ds_grid_desc_mblock_mperblock_nblock_nperblock[I1],
make_multi_index(block_m_id,
get_thread_local_1d_id() * 8 / 64,
block_n_id,
0)
);
const index_t num_k_block_main_loop = __builtin_amdgcn_readfirstlane(
(a_grid_desc_ak0_m_ak1.GetLength(I0) * a_grid_desc_ak0_m_ak1.GetLength(I2)) /
KPerBlock);