ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-07-01 04:07:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check that number of convolution groups is multiple of merged groups.

Browse Source
This commit is contained in:
Ville Pietilä
2025-10-07 15:05:09 +00:00
parent 438787dbb6
commit fdfbd1e770
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
include/ck_tile/ops/grouped_convolution/kernel/grouped_convolution_backward_weight_kernel.hpp
View File

@@ -626,17 +626,17 @@ struct GroupedConvolutionBackwardWeightKernel
return false;
}
// if constexpr (GroupedConvTraitsType_::NumGroupsToMerge > 1)
// {
// const index_t ConvG = kargs.wei_g_k_c_xs_lengths[number<0>{}];
// if (ConvG % GroupedConvTraitsType_::NumGroupsToMerge != 0)
// {
// CK_TILE_ERROR("ConvG must be a multiple of NumGroupsToMerge!");
// return false;
// }
if constexpr(GroupedConvTraitsType_::NumGroupsToMerge > 1)
{
const index_t ConvG = kargs.wei_g_k_c_xs_lengths[number<0>{}];
if(ConvG % GroupedConvTraitsType_::NumGroupsToMerge != 0)
{
CK_TILE_ERROR("ConvG must be a multiple of NumGroupsToMerge!");
return false;
}
// // TODO: Should we also check that GemmM <= MPerBlock and GemmN <= NPerBlock?
// }
// TODO: Should we also check that GemmM <= MPerBlock and GemmN <= NPerBlock?
}
return true;
}