Commit Graph

2624 Commits

Author SHA1 Message Date
Ville Pietilä
8bfbdf6935 Add instance registry. 2025-11-05 15:03:19 +00:00
Ville Pietilä
e96fb6555c Fix code generation. 2025-11-05 14:23:49 +00:00
Ville Pietilä
32d40f188c Fix build paths. 2025-11-05 13:51:48 +00:00
Ville Pietilä
82f04195f9 Add generation of device op instances via script. 2025-11-05 13:19:35 +00:00
Ville Pietilä
ea5e21aa09 Remove redundant fields from JSON. 2025-11-05 06:07:09 -06:00
Ville Pietilä
fff8d16e93 Fix build. 2025-11-05 04:31:37 -06:00
Ville Pietilä
f410a34b43 Add missing concept. 2025-11-05 04:31:29 -06:00
Ville Pietilä
bcb916f45e Merge remote-tracking branch 'origin/vpietila/ckb-remove-explicit-device-op-flag' into vpietila/ckb-fwd-bwd-instances 2025-11-05 04:10:09 -06:00
Ville Pietilä
3c6aae58f7 Refactor JSON scripts. 2025-11-05 04:08:53 -06:00
Ville Pietilä
deec3a0dc1 Remove explicit device op flag from from convolution signature. 2025-11-05 09:17:46 +00:00
Ville Pietilä
116e0c1c61 Move generator script. 2025-11-05 02:29:00 -06:00
Ville Pietilä
f0291b7956 Added missing copyright. 2025-11-05 08:15:20 +00:00
Ville Pietilä
30df33538a Merge remote-tracking branch 'origin/develop' into vpietila/ckb-fwd-instance-test-improvements 2025-11-05 08:08:12 +00:00
andrew clark
3b076b0b74 Collecting redis stats (#3149) 2025-11-04 18:55:11 -08:00
Illia Silin
930423ab3b Initialize new variable to prevent c++17 compiler error (#3156)
* initialize new variable to prevent c++17 compiler error

* build for gfx90a using -std=c++17 flag
2025-11-04 18:54:14 -08:00
Vidyasagar Ananthan
31c019f589 Chunk Ctests so we dont run into large number of tests error (#3050)
* Chunk Ctests so we dont run into large number of tests error

* Addressing feedback from copilot
2025-11-04 10:31:32 -08:00
Cong Ma
5abe4109e0 Introduces the new partitioner to implement the reduction StreamK kernel. (#3107)
* Introduces the new partitioner to implement the reduction StreamK kernel

* Add more doc text to functions

* Add persistent-dp option to streamk example

* Update example/ck_tile/40_streamk_gemm/README.md
2025-11-04 10:32:17 -07:00
Thomas Ning
13ba06f1e7 fix the blockscale 2d case (#3148)
Co-authored-by: Aviral Goel <aviral.goel@amd.com>
2025-11-04 11:55:23 -05:00
Ville Pietilä
4beee639b3 Add python script to create the serialized JSON file of the fwd instances. 2025-11-04 09:01:28 -06:00
John Shumway
0be0288f58 [CK_BUILDER] Update copyright messages. (#3150)
* Update copyright messages.

Copyright messages should no longer include a year. This PR updates all 38 source files to the new format.

* Switch to (C) from unicode copyright symbol.

The unicodein comments  was causing compilation errors.
therock-7.10
2025-11-04 15:35:16 +01:00
John Shumway
6dbee64886 [CK_BUILDER] Add backward weight instance traits for xdl cshuffle. (#3143)
* Add backward weight instance traits for xdl cshuffle.

To keep instance test file sizes reasonable, we start a new test_bwd_weight_instances_traits.cpp test file.

* Fix copyright notices.

* Remove (c) symbol, replace with (C).

Having UTF-8 in source caused an error with code generation.
2025-11-04 15:34:00 +01:00
Bartłomiej Kocot
8681ced962 [CK TILE] Refactor Conv configs and Conv Elementwise (#3151)
* [CK TILE] Refactor Conv configs and Conv Elementwise

* fix
2025-11-04 15:04:53 +01:00
Ville Pietilä
1cf6e00cad Merge branch 'vpietila/ckb-fwd-bwd-instances' of github.com:ROCm/composable_kernel into vpietila/ckb-fwd-bwd-instances 2025-11-04 07:52:27 -06:00
Ville Pietilä
e5528129c8 Add structured representation of the instances. 2025-11-04 07:46:30 -06:00
Ville Pietilä
37030df32d Add workspace definition file. 2025-11-04 07:46:30 -06:00
Ville Pietilä
8e501e5c70 Add validation rules for builder parameters. 2025-11-04 07:46:30 -06:00
Ville Pietilä
156aeb7298 Move instances assets to a dedicated directory. 2025-11-04 07:46:30 -06:00
Ville Pietilä
dccd8b4ac4 Add listing of all fwd and bwd device ops and instances. 2025-11-04 07:46:30 -06:00
Ville Pietilä
0247a89f59 Add structured representation of the instances. 2025-11-04 06:52:18 -06:00
Ville Pietilä
5d6427a0fd Removed unnecessary includes. 2025-11-04 12:16:09 +00:00
Ville Pietilä
c1db7497af Fix clang-formatting. 2025-11-04 12:04:09 +00:00
Ville Pietilä
930dcaab25 Merge branch 'develop' into vpietila/ckb-fwd-instance-test-improvements 2025-11-04 13:48:41 +02:00
Ville Pietilä
69a93a57f0 Change if-else statements into switch in conv factory. 2025-11-04 10:57:50 +00:00
Ville Pietilä
adf0a80290 clang-format 2025-11-04 08:59:57 +00:00
Ville Pietilä
0ac48abe61 Improve ckb fwd conv instance tests. 2025-11-04 08:58:25 +00:00
Bartłomiej Kocot
99f38e4d9b [CK TILE] Refactor grouped conv fwd large tensor (#3144) 2025-11-04 00:34:48 +01:00
Vidyasagar Ananthan
c7ded76cc7 Adding note on CMake convenience script (#3139)
* Adding note on convenience script

* Addressing feedback

* Update README.md

reword

---------

Co-authored-by: Max Podkorytov <4273004+tenpercent@users.noreply.github.com>
2025-11-03 12:21:57 -08:00
Enrico Degregori
507d81c3af Fix splitk preshuffle (#3137)
* Fix splitK multiply_multiply_wp

* Add tests for gemm_multiply_multiply_wp

* Add tests for gemm_universal_preshuffle (KBatch = 1)

* Add tests gemm_blockscale_wp

* Fix splitk gemm universal preshuffle

* Run new tests on arch supporting fp8

* Restore example

* Fix strides profiler

* Fix tests

* Fix clang format

* Finalize profiler preshuffle with tolerances

* Minor improvements to splitk related changes

* Address review comments: clang format and ckProfiler typo

* Remove b_k_split_offset from SplitKBatchOffset struct
2025-11-03 11:59:01 -08:00
Thomas Ning
057b7d43b4 fix the compv4 and async pipeline when tile handler is 1 (#3141) 2025-11-03 09:37:35 -08:00
Ville Pietilä
1893079fdc WIP: Builder for expected test results. 2025-11-03 17:06:01 +00:00
Emily Martins
2ec57a8e70 Replace CK_TILE_PIPELINE macros with a common enum
This change replaces pipeline macros like CK_TILE_PIPELINE_COMPUTE_V3,
CK_TILE_PIPELINE_MEMORY, etc in the CK Tile examples with a common enum
called GemmPipeline to reduce code duplication.
2025-11-03 09:35:05 -07:00
Ville Pietilä
15f010138b Fix namespace. 2025-11-03 16:06:14 +00:00
Michael Mcminn
afe1ff618d Ud fix moe sorting gfx908 (#2720)
* Adding a ds permute fallback for the gfx908 and older for row_newbcast:7 instruction

* Better macro for selecting ROW_NEWBCAST

* clang-format the update

---------

Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
2025-11-03 07:31:31 -08:00
Ville Pietilä
0d68298d43 Separate test configs from other testing assets. 2025-11-03 14:39:54 +00:00
Ville Pietilä
9fc3d64e16 Rename test config file. 2025-11-03 14:33:56 +00:00
Ville Pietilä
6ded2ab92a Remove code duplication in fwd conv builder tests. 2025-11-03 14:06:45 +00:00
Ville Pietilä
9b78a23bb7 Add workspace definition file. 2025-11-03 09:57:38 +00:00
Ville Pietilä
fd15355261 Add validation rules for builder parameters. 2025-11-03 09:57:27 +00:00
Ville Pietilä
aeaa457e75 Move instances assets to a dedicated directory. 2025-11-03 09:56:59 +00:00
msaffari-amd
d405641f06 Ck tile engine gemm unit tests exapand test coverage (#3025)
* initial commit for testing datatypes, layouts and traits

* correct warp tile size for small datatype config to make a validate instance for fp16, bf16, fp8

* add tile size coverage test

* Cover more tests, parallel instance generation, documentation

* update cmakelist to run more tests

* initial codes to support add test params in json file

* add congurable  problem sizes for different tests

* modify README.md

* clean test_gemm_simple code

* correct padding coverage test

* Add comprehensive and quick tile size config files

* remove fp64 from datatypes

* update documents. manage selecting tile_size config (quick or Comprehensive)

* correct padding test problem sizes

* update comprehensive test and correct documents

* Skip GEMM tests with unsupported arguments instead of failing

* change gen_single instead of gen_indivisual because of an issue. add splitk tests to tile_size_quick_config

* clean CMakeList, remod py file

* Refactor test configs: Rename tile_size to coverage, remove separate traits config,  clean cmakefile, readme

* update fp32, fp8 to test all layouts, clean documents and comments

* limit fp32 test layouts to rcr because of compilation error on some gpus

* remove fp32 because of the removing from gemm_instance_builder, make quick test smaller, updating comments

* Fix fp8/bf8 test failures on gfx950 by adding OCP FP8 format support

* Reduce quick_coverage test count from ~250 to ~144 for faster CI
2025-11-03 10:29:16 +01:00