Commit Graph

1548 Commits

Author SHA1 Message Date
PoYen, Chen
a8a2275aca Fix wrong arugment count 2024-08-13 08:42:23 +00:00
PoYen, Chen
d96752d0f5 Refine smoke_test_fwd.sh 2024-08-13 08:36:04 +00:00
PoYen, Chen
3dd6ef61ef Re-order pipeline paremeters 2024-08-13 07:38:41 +00:00
PoYen, Chen
19c19d8bd3 Only expose necessary methods (not attributes) 2024-08-13 07:26:26 +00:00
PoYen, Chen
c54de6416a Rename TileWindowNavigator to PageBlockNavigator 2024-08-13 07:23:40 +00:00
PoYen, Chen
e8603dc21a Add missing comment 2024-08-08 20:40:50 +00:00
PoYen, Chen
822d5dcd8e Fix wrong seqlen for kvcache 2024-08-08 20:39:36 +00:00
PoYen, Chen
6a399ea47e Use generic lambda to init all the api traits/args 2024-08-08 19:22:53 +00:00
PoYen, Chen
9206808835 Move functors to the begining of validation code 2024-08-08 18:01:10 +00:00
PoYen, Chen
028d89862a Wrap code by #if directives 2024-08-08 17:58:49 +00:00
PoYen, Chen
d2f5d0910a Remove no-longer used pipeline files 2024-08-08 17:40:05 +00:00
PoYen, Chen
9dddf6e437 Rename 'max_num_blocks' to 'max_num_page_blocks' 2024-08-08 17:38:08 +00:00
PoYen, Chen
e3a4bfba88 Show more detailed warning message 2024-08-08 17:35:36 +00:00
PoYen, Chen
d3624a03de Merge branch 'develop' into feature/fmha-fwd-appendkv 2024-08-08 17:26:53 +00:00
PoYen, Chen
3e2b69e163 Display more info for specific kernels 2024-08-08 17:26:09 +00:00
PoYen, Chen
c8f63d4848 Separate more non-splitkv & splitkv traits/args 2024-08-08 16:54:00 +00:00
PoYen, Chen
677d9b28dd Use generic lambda to init traits objects 2024-08-08 16:38:17 +00:00
Illia Silin
ae3b8ff86c check if the coerce-illegal-types flag is supported (#1451) 2024-08-08 07:29:29 -07:00
Illia Silin
8a75728406 add rocm-llvm-dev package to docker image (#1452) 2024-08-08 07:29:13 -07:00
PoYen, Chen
2f42e4460f Allow problem types without define kHasDropout attr 2024-08-08 10:53:42 +00:00
PoYen, Chen
a0d2163045 Remove dropout code in splitkv kernel 2024-08-08 10:21:34 +00:00
PoYen, Chen
9d9c5a6c24 Fix compilation errors 2024-08-08 08:26:55 +00:00
PoYen, Chen
247e135cfc Remove fmha_fwd_dispatch() 2024-08-08 08:15:04 +00:00
PoYen, Chen
291e9b4bbb Separate splitkv/non-splitkv args/traits 2024-08-08 08:07:03 +00:00
Juan Manuel Martinez Caamaño
901e5f1540 Remove reinterpret_cast uses that result in undefined behaviour. (#1445)
* Remove reinterpret_cast uses that result in undefined behaviour. Use a bitcast instead.

See https://en.cppreference.com/w/cpp/language/reinterpret_cast#Type_accessibility

Closes #1439

* fix clang format

---------

Co-authored-by: illsilin <Illia.Silin@amd.com>
2024-08-07 11:49:02 -07:00
Illia Silin
5df10432d8 upgrade to rocm6.2 as new default compiler (#1448) 2024-08-07 09:38:43 -07:00
PoYen, Chen
655b13b059 Rename option s_k_new to s_knew 2024-08-07 15:31:54 +00:00
PoYen, Chen
cef9da0a76 Remove debug macro usages 2024-08-07 15:26:43 +00:00
PoYen, Chen
b6c2f2f01d Add missing group mode argument 2024-08-07 15:22:57 +00:00
dependabot[bot]
a71d407e35 Bump rocm-docs-core from 1.6.1 to 1.6.2 in /docs/sphinx (#1449)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.6.1 to 1.6.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.6.1...v1.6.2)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-07 08:22:38 -07:00
Illia Silin
12c1f68dd9 Run CK_TILE FMHA benchmarks and collect the performance data. (#1447)
* run ck_tile benchmarks after the smoke tests and store logs

* change the path of fmha benchmark logs

* change the way of stashig ck_tile fmha logs

* prevent the errors in stages where no logs are generated

* fix the ck_tile fmha log names and headers

* generate the fmha performance logs in the root folder

* change jenkins scrip arguments format

* use exact file names for stashing

* modify scripts to process FMHA performance results

* unstash FMHA logs before parsing them
2024-08-07 08:18:26 -07:00
PoYen, Chen
55ce2948a9 Always add fmha_fwd() api 2024-08-07 13:43:14 +00:00
PoYen, Chen
eda78d1a10 Merge branch 'develop' into feature/fmha-fwd-appendkv 2024-08-07 12:17:45 +00:00
PoYen, Chen
1b96dc2592 Donot perform write again if already in last page-block 2024-08-07 12:00:15 +00:00
PoYen, Chen
f265742b63 Handle cross-page-block write 2024-08-07 09:33:41 +00:00
PoYen, Chen
40f0d01e29 Allow transit tile_window to another page-block 2024-08-07 09:29:55 +00:00
PoYen, Chen
838f9955fd Fix wrong strides for appendkv kernel 2024-08-07 08:06:47 +00:00
PoYen, Chen
26ed468ac6 Pass re-created tile window to pipeline 2024-08-07 06:00:17 +00:00
PoYen, Chen
78209c7326 Fix wrong tensor descriptor lengths 2024-08-07 05:59:26 +00:00
PoYen, Chen
7789b53e15 Add tile navigators to the appendkv kernel 2024-08-07 04:51:21 +00:00
PoYen, Chen
443a528adc Add block_table kernel args for appendkv kernel 2024-08-07 04:27:15 +00:00
PoYen, Chen
15d0034a64 Add paged-kv codegen logic for appendkv kernels 2024-08-07 04:19:45 +00:00
Max Podkorytov
886d14ccb2 modify python wrapper for addmm (#1441) 2024-08-06 15:09:27 -07:00
Haocong WANG
6fc7bff58f Limit fp8only operator build arch in ckProfiler (#1443) 2024-08-06 14:29:14 -07:00
Jun Liu
afbf6350f3 Fix ROCm 6.2 compiler not fully supporting gfx12 when building CK with INSTANCES_ONLY (#1446) 2024-08-06 13:06:53 -07:00
Juan Manuel Martinez Caamaño
fd9ef4e678 Add missing constexpr to if conditions (#1444) 2024-08-06 11:40:34 -07:00
bibek
840c5397bb adding mha as static lib (#1366)
* adding mha as static lib

* add fmha fwd compile options

* typo

* fix python version

* python version to 3

* increase path length

* add max path flag in mha cmake

* fix long path issue

* mha currently only runs in gfx94x

* only buld mha in mi300

* populate gpu_list

* add mha compile flags

* avoid building mha in gpu other then gfx94x

* some comments and  include ck_tile in rocm

* use rocm_install

* place ck_tile in include

* correct ck_tile path

---------

Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
2024-08-06 11:17:10 -05:00
jakpiase
b74d4d4d54 Fix for beta!=0 in reduce (#1440)
* fix for beta!=0 in reduce

* add reviewers suggestions
2024-08-06 09:10:39 -07:00
PoYen, Chen
b98985262d Add missing kernel arguments for group mode 2024-08-06 14:54:07 +00:00
PoYen, Chen
db31475e07 Unify origin 2024-08-06 08:37:29 +00:00