ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-03-18 14:17:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
Page: Code Review
Pages
Build Analysis using ClangBuildAnalyzer and Ninjatracing Code Review Coding Style Composable Kernel Overview Home Pseudo code of fusion of a convolution (or GEMM) operator and an epilogue function
Clone
4
Code Review
Chao Liu edited this page 2022-02-23 17:51:03 -06:00
Table of Contents

Overall process

  • Before task start
    • Assign a reviewer
    • Decide whether to add unit test
  • PR need to pass CI, before signaled as ready for review
  • PR review process
    • Developer signal PR is ready
    • Set up a meeting with reviewer if there is disagreement

  • For a review comment, only the original reviewer can "resolve" it.
  • If a PR is merged before all comments are resolved
    • A post-merge issue need to be created to track that PR and all unaddressed comments.
  • Add prefix WIP: in the title if a PR is created but not ready for review and merge. Also the CI system could make use of this.