SillyTavern/Extension-Randomizer
1
0
Fork 0
mirror of https://github.com/SillyTavern/Extension-Randomizer.git synced 2026-10-15 13:31:56 +00:00
Code Issues Projects Packages Wiki Activity

[PR #1] [MERGED] labelRef should be looking for the input, not a div. #1

New issue
Closed
opened 2026-10-15 13:26:41 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-15 13:26:41 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/Extension-Randomizer/pull/1
Author: @Oninaig
Created: 1/2/2024
Status: ✅ Merged
Merged: 1/2/2024
Merged by: @Cohee1207

Base: main ← Head: patch-1

📝 Commits (1)

  • 7ac4309 labelRef should be looking for the input, not a div.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 index.js (+1 -1)

📄 Description

$(this) is already a div and the only child is the input so this would never find anything. Example:

<div class="range-block-counter">
     <input type="number" min="0" max="2.0" step="0.01" data-for="temp_openai" id="temp_counter_openai">
</div>

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/Extension-Randomizer/pull/1 **Author:** [@Oninaig](https://github.com/Oninaig) **Created:** 1/2/2024 **Status:** ✅ Merged **Merged:** 1/2/2024 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`7ac4309`](https://github.com/SillyTavern/Extension-Randomizer/commit/7ac430948fdba3188a18ac2d3f31377a2690ea36) labelRef should be looking for the input, not a div. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `index.js` (+1 -1) </details> ### 📄 Description `$(this)` is already a div and the only child is the input so this would never find anything. Example: ``` <div class="range-block-counter"> <input type="number" min="0" max="2.0" step="0.01" data-for="temp_openai" id="temp_counter_openai"> </div> ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 13:26:41 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SillyTavern/Extension-Randomizer#1
No description provided.