SillyTavern/Extension-SamplerCommands
1
0
Fork 0
mirror of https://github.com/SillyTavern/Extension-SamplerCommands.git synced 2026-10-15 13:32:00 +00:00
Code Issues 1 Projects Packages Wiki Activity

[PR #2] [MERGED] Switch classes on leftPanel in order to not lose open/close state #2

New issue
Closed
opened 2026-10-15 13:26:56 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-15 13:26:56 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/Extension-SamplerCommands/pull/2
Author: @pfn
Created: 12/23/2025
Status: ✅ Merged
Merged: 12/24/2025
Merged by: @Cohee1207

Base: main ← Head: left-panel-vis-bug

📝 Commits (1)

  • 63e58da Refactor visibility check and improve enumerating sampler parameters

📊 Changes

1 file changed (+22 additions, -13 deletions)

View changed files

📝 index.js (+22 -13)

📄 Description

leftPanel visibility state was getting messed up when using /sampler-{get,set} because display was being explicitly set on the element rather than using the classes it typically obeys.

Switch to adding/removing the correct classes so that the state remains consistent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/Extension-SamplerCommands/pull/2 **Author:** [@pfn](https://github.com/pfn) **Created:** 12/23/2025 **Status:** ✅ Merged **Merged:** 12/24/2025 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `main` ← **Head:** `left-panel-vis-bug` --- ### 📝 Commits (1) - [`63e58da`](https://github.com/SillyTavern/Extension-SamplerCommands/commit/63e58dabc0f4fb1ee6ad4cdb95f47563f8701acd) Refactor visibility check and improve enumerating sampler parameters ### 📊 Changes **1 file changed** (+22 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `index.js` (+22 -13) </details> ### 📄 Description `leftPanel` visibility state was getting messed up when using `/sampler-{get,set}` because `display` was being explicitly set on the element rather than using the classes it typically obeys. Switch to adding/removing the correct classes so that the state remains consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 13:26:56 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/hasvisibleancestor-perf
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SillyTavern/Extension-SamplerCommands#2
No description provided.