amd/blis
1
0
Fork 0
mirror of https://github.com/amd/blis.git synced 2026-04-20 07:38:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing the coverity issues with CID: 23269 and CID: 137049 (#180)

Browse Source 
Fixing some coverity issues that detected out of bounds array accesses.

AMD-Internal: CPUPL-6579
Co-authored-by: Rohan Rayan rohrayan@amd.com
This commit is contained in:
Rayan, Rohan
2025-09-16 10:01:52 +05:30
committed by GitHub
parent 5de25ce9a7
commit 2e7f387d13
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frame/1m/packm/bli_packm_blk_var1.c
View File

@@ -130,8 +130,8 @@ void bli_packm_blk_var1
obj_t kappa;
void* buf_kappa;
func_t* packm_kers;
void_fp packm_ker;
func_t* packm_kers = NULL;
void_fp packm_ker = NULL;
FUNCPTR_T f;
@@ -214,7 +214,7 @@ void bli_packm_blk_var1
// for the current schema.
const dim_t i = bli_pack_schema_index( schema );
packm_kers = &packm_struc_cxk_kers[ i ];
if ( i < 3 ) packm_kers = &packm_struc_cxk_kers[ i ];
}
#if 0
else // cntx's packm func_t overrides
@@ -227,7 +227,7 @@ void bli_packm_blk_var1
#endif
// Query the datatype-specific function pointer from the func_t object.
packm_ker = bli_func_get_dt( dt_p, packm_kers );
if ( packm_kers ) packm_ker = bli_func_get_dt( dt_p, packm_kers );
// Index into the type combination array to extract the correct
// function pointer.
@@ -326,6 +326,10 @@ void PASTEMAC(ch,varname) \
ctype* restrict p_use; \
doff_t diagoffp_i; \
\
\
\
/* If the packing kernel is NULL for some reason, then return */ \
if(packm_ker == NULL) return; \
\
/* If C is zeros and part of a triangular matrix, then we don't need
to pack it. */ \

2
kernels/zen5/3/bli_trsm_small_zen5.c
View File

@@ -121,7 +121,7 @@ err_t bli_trsm_small_zen5
bool transa = bli_obj_has_trans(a);
num_t dt = bli_obj_dt(a);
if (dt == BLIS_SCOMPLEX || dt == BLIS_FLOAT)
if (dt != BLIS_DOUBLE && dt != BLIS_DCOMPLEX)
{
return BLIS_NOT_YET_IMPLEMENTED;
}