amd/blis
1
0
Fork 0
mirror of https://github.com/amd/blis.git synced 2026-05-13 18:52:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable modification of KC in the gemmsup kernels. (#648)

Browse Source 
This led to a ~50% performance reduction for certain gemm operations (but not others?). See #644 for example.
This commit is contained in:
Devin Matthews
2022-07-27 13:54:17 -05:00
committed by GitHub
parent 4dde947e2e
commit 56de31b00f
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
frame/3/bli_l3_sup_var1n2m.c
View File

@@ -295,6 +295,9 @@ void PASTEMAC(ch,varname) \
const dim_t MC0 = bli_cntx_get_l3_sup_blksz_def_dt( dt, BLIS_MC, cntx ); \
const dim_t KC0 = bli_cntx_get_l3_sup_blksz_def_dt( dt, BLIS_KC, cntx ); \
\
/* Disable modification of KC since it seems to negatively impact certain operations (#644). */ \
dim_t KC = KC0; \
/* \
dim_t KC; \
if ( packa && packb ) \
{ \
@@ -320,7 +323,7 @@ void PASTEMAC(ch,varname) \
stor_id == BLIS_CCR ) KC = (( KC0 / 4 ) / 4 ) * 4; \
else KC = KC0; \
} \
else /* if ( !packa && !packb ) */ \
else *//* if ( !packa && !packb ) *//* \
{ \
if ( FALSE ) KC = KC0; \
else if ( stor_id == BLIS_RRC || \
@@ -330,7 +333,7 @@ void PASTEMAC(ch,varname) \
else if ( m <= 3*MR && n <= 3*NR ) KC = (( KC0 / 3 ) / 4 ) * 4; \
else if ( m <= 4*MR && n <= 4*NR ) KC = KC0 / 4; \
else KC = (( KC0 / 5 ) / 4 ) * 4; \
} \
}*/ \
\
/* Nudge NC up to a multiple of MR and MC up to a multiple of NR.
NOTE: This is unique to variant 1 (ie: not performed in variant 2)
@@ -932,6 +935,9 @@ void PASTEMAC(ch,varname) \
const dim_t MC = bli_cntx_get_l3_sup_blksz_def_dt( dt, BLIS_MC, cntx ); \
const dim_t KC0 = bli_cntx_get_l3_sup_blksz_def_dt( dt, BLIS_KC, cntx ); \
\
/* Disable modification of KC since it seems to negatively impact certain operations (#644). */ \
dim_t KC = KC0; \
/* \
dim_t KC; \
if ( packa && packb ) \
{ \
@@ -957,7 +963,7 @@ void PASTEMAC(ch,varname) \
stor_id == BLIS_CCR ) KC = (( KC0 / 4 ) / 4 ) * 4; \
else KC = KC0; \
} \
else /* if ( !packa && !packb ) */ \
else *//* if ( !packa && !packb ) *//* \
{ \
if ( stor_id == BLIS_RRR || \
stor_id == BLIS_CCC ) KC = KC0; \
@@ -968,7 +974,7 @@ void PASTEMAC(ch,varname) \
else if ( m <= 3*MR && n <= 3*NR ) KC = (( KC0 / 3 ) / 4 ) * 4; \
else if ( m <= 4*MR && n <= 4*NR ) KC = KC0 / 4; \
else KC = (( KC0 / 5 ) / 4 ) * 4; \
} \
}*/ \
\
/* Query the maximum blocksize for NR, which implies a maximum blocksize
extension for the final iteration. */ \