Code cleanup and warnings fixes

- Removed some additional compiler warnings reported by GCC 12.1
- Fixed a couple of typos in comments
- frame/3/bli_l3_sup.c: routines were returning before final call
  to AOCL_DTL_TRACE_EXIT
- frame/2/gemv/bli_gemv_unf_var1_amd.c: bli_multi_sgemv_4x2 is
  only defined in header file if BLIS_ENABLE_OPENMP is defined

AMD-Internal: [CPUPL-2460]
Change-Id: I2eacd5687f2548d8f40c24bd1b930859eefbbcde

blastest/f2c/rdfmt.c

@@ -249,9 +249,13 @@ static int rd_F(ufloat *p, int w, int d, ftnlen len)
 		}
 	while(ch == ' ') {
 blankdrop:
-		if (!w--) goto zero; GET(ch); }
-	while(ch == '0')
-		{ if (!w--) goto zero; GET(ch); }
+		if (!w--) goto zero;
+		GET(ch);
+	}
+	while(ch == '0') {
+		if (!w--) goto zero;
+		GET(ch);
+	}
 	if (ch == ' ' && f__cblank)
 		goto blankdrop;
 	scale1 = f__scale;
@@ -262,7 +266,7 @@ digloop1:
 digloop1e:
 		if (!w--) goto done;
 		GET(ch);
-		}
+	}
 	if (ch == ' ') {
 		if (f__cblank)
 			{ ch = '0'; goto digloop1; }

frame/2/gemv/bli_gemv_unf_var1_amd.c

@@ -519,6 +519,7 @@ void bli_sgemv_unf_var1
 
     if ( ( nt_max > 1 ) & ( is_omp_mt_enabled == TRUE ) )
     {
+#ifdef BLIS_ENABLE_OPENMP
         b_fuse = 4;
 
         //Setting the thread count to the maximum number of threads provided
@@ -544,6 +545,7 @@ void bli_sgemv_unf_var1
           cntx,
           nt
         );
+#endif// BLIS_ENABLE_OPENMP
     }
     else
     {

frame/3/bli_l3_sup.c

@@ -152,8 +152,7 @@ err_t bli_gemmsup
     // Query the small/unpacked handler from the context and invoke it.
     gemmsup_oft gemmsup_fp = bli_cntx_get_l3_sup_handler( BLIS_GEMM, cntx );
 
-    return
-    gemmsup_fp
+    err_t ret_gemmsup_fp = gemmsup_fp
     (
       alpha,
       a,
@@ -165,6 +164,7 @@ err_t bli_gemmsup
     );
 
     AOCL_DTL_TRACE_EXIT(AOCL_DTL_LEVEL_TRACE_2);
+    return ret_gemmsup_fp;
 }
 
 err_t bli_gemmtsup
@@ -285,8 +285,7 @@ printf( "dims: %d %d %d (threshs: %d %d %d)\n",
     // Query the small/unpacked handler from the context and invoke it.
     gemmtsup_oft gemmtsup_fp = bli_cntx_get_l3_sup_handler( BLIS_GEMMT, cntx );
 
-    return
-    gemmtsup_fp
+    err_t ret_gemmtsup_fp = gemmtsup_fp
     (
       alpha,
       a,
@@ -298,6 +297,7 @@ printf( "dims: %d %d %d (threshs: %d %d %d)\n",
     );
 
     AOCL_DTL_TRACE_EXIT(AOCL_DTL_LEVEL_TRACE_2);
+    return ret_gemmtsup_fp;
 }
 
 err_t bli_syrksup
@@ -414,8 +414,7 @@ printf( "dims: %d %d %d (threshs: %d %d %d)\n",
     // Query the small/unpacked handler from the context and invoke it.
     gemmtsup_oft gemmtsup_fp = bli_cntx_get_l3_sup_handler( BLIS_GEMMT, cntx );
 
-    return
-    gemmtsup_fp
+    err_t ret_gemmtsup_fp = gemmtsup_fp
     (
       alpha,
       a,
@@ -427,4 +426,5 @@ printf( "dims: %d %d %d (threshs: %d %d %d)\n",
     );
 
     AOCL_DTL_TRACE_EXIT(AOCL_DTL_LEVEL_TRACE_2);
+    return ret_gemmtsup_fp;
 }

frame/base/bli_init.c

@@ -5,7 +5,7 @@
    libraries.
 
    Copyright (C) 2014, The University of Texas at Austin
-   Copyright (C) 2018 - 2019, Advanced Micro Devices, Inc.
+   Copyright (C) 2020 - 2022, Advanced Micro Devices, Inc. All rights reserved.
 
    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions are
@@ -74,7 +74,7 @@ void bli_finalize_auto( void )
 
 void bli_init_apis( void )
 {
-	/* Initialzie DTL Libary with trace level set by the user */
+	/* Initialize DTL Library with trace level set by the user */
 	AOCL_DTL_INITIALIZE(AOCL_DTL_TRACE_LEVEL);
 	// Initialize various sub-APIs.
 	bli_gks_init();

frame/util/bli_util_update.c

@@ -4,7 +4,7 @@
    An object-based framework for developing high-performance BLAS-like
    libraries.
 
-   Copyright (C) 2020 - 21, Advanced Micro Devices, Inc. All rights reserved.
+   Copyright (C) 2020 - 2022, Advanced Micro Devices, Inc. All rights reserved.
 
    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions are
@@ -212,12 +212,12 @@ void PASTEMAC(ch, varname) \
 				c[m*rs_c + n].imag = ct[m*rs_ct + n].imag; \
 			} \
 \
-			for(; m < m_cur; m++) \
-				for(n = 0; n < n_cur; n++) \
-				{ \
-					c[m*rs_c + n].real = ct[m*rs_ct + n].real; \
-					c[m*rs_c + n].imag = ct[m*rs_ct + n].imag; \
-				} \
+		for(; m < m_cur; m++) \
+			for(n = 0; n < n_cur; n++) \
+			{ \
+				c[m*rs_c + n].real = ct[m*rs_ct + n].real; \
+				c[m*rs_c + n].imag = ct[m*rs_ct + n].imag; \
+			} \
 	} \
 \
 	return; \