GTestSuite: Misc fixes (2)

Various changes:
- Fixed undeclared variables in her, her2, syr and syr2 IIT_ERS tests
- Correct typos in comments

AMD-Internal: [CPUPL-7386]
This commit is contained in:
Smyth, Edward
2026-01-16 00:33:16 +00:00
committed by GitHub
parent 824e289899
commit bd99d6cd92
28 changed files with 69 additions and 63 deletions

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -49,8 +49,8 @@
the matrix multiplication
* @param[in] conjx specifies the form of xp to be used in
the vector multiplication (BLIS_TYPED only)
* @param[in] m specifies the number of rows of the matrix A
* @param[in] n specifies the number of columns of the matrix A
* @param[in] m specifies the number of rows of the matrix A
* @param[in] n specifies the number of columns of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap
* @param[in] lda specifies leading dimension of the matrix.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -46,8 +46,8 @@
the vector multiplication (BLIS_TYPED only)
* @param[in] conjy specifies the form of yp to be used in
the vector multiplication (BLIS_TYPED only)
* @param[in] m specifies the number of rows of the matrix A
* @param[in] n specifies the number of columns of the matrix A
* @param[in] m specifies the number of rows of the matrix A
* @param[in] n specifies the number of columns of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] xp specifies pointer which points to the first element of xp
* @param[in] incx specifies storage spacing between elements of xp.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -105,7 +105,7 @@ TYPED_TEST(hemv_IIT_ERS, invalid_storage)
/*
Incorrect Input Testing(IIT)
BLAS exceptions get triggered in the following cases(for GEMM):
BLAS exceptions get triggered in the following cases (for HEMV):
1. When UPLO != 'N' || UPLO != 'T' || UPLO != 'C' (info = 1)
3. When n < 0 (info = 2)
4. When lda < m (info = 5)

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -48,7 +48,7 @@
the matrix-vector multiplication (BLIS_TYPED only)
* @param[in] storage specifies the form of storage in the memory matrix A
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap
* @param[in] lda specifies leading dimension of the matrix.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -60,6 +60,7 @@ TYPED_TEST(her_IIT_ERS, invalid_storage)
static const char CONJ = 'n';
static const gtint_t N = 4;
// Set the dimension for row/col of A and B, depending on the value of trans.
gtint_t incx = 1;
gtint_t LDA = N;
RT alpha;
testinghelpers::initone<RT>( alpha );

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -42,7 +42,7 @@
* @brief Performs the operation:
* A := alpha*x*x**H + A
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] m specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] xp specifies pointer which points to the first element of xp
* @param[in] incx specifies storage spacing between elements of xp.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -59,6 +59,8 @@ TYPED_TEST(her2_IIT_ERS, invalid_storage)
static const char CONJ = 'n';
static const gtint_t N = 4;
// Set the dimension for row/col of A and B, depending on the value of trans.
gtint_t incx = 1;
gtint_t incy = 1;
gtint_t LDA = N;
T alpha;
testinghelpers::initone<T>( alpha );

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -43,7 +43,7 @@
* A := alpha*x*y**T + alpha*y*x**T + A,
* @param[in] storage specifies the form of storage in the memory matrix A
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] xp specifies pointer which points to the first element of xp
* @param[in] incx specifies storage spacing between elements of xp.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -105,7 +105,7 @@ TYPED_TEST(symv_IIT_ERS, invalid_storage)
/*
Incorrect Input Testing(IIT)
BLAS exceptions get triggered in the following cases(for GEMM):
BLAS exceptions get triggered in the following cases (for SYMV):
1. When UPLO != 'N' || UPLO != 'T' || UPLO != 'C' (info = 1)
3. When n < 0 (info = 2)
4. When lda < m (info = 5)

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -43,7 +43,7 @@
* y := alpha*A*x + beta*y
* @param[in] storage specifies the form of storage in the memory matrix A
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap
* @param[in] lda specifies leading dimension of the matrix.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -59,6 +59,7 @@ TYPED_TEST(syr_IIT_ERS, invalid_storage)
static const char CONJ = 'n';
static const gtint_t N = 4;
// Set the dimension for row/col of A and B, depending on the value of trans.
gtint_t incx = 1;
gtint_t LDA = N;
T alpha;
testinghelpers::initone<T>( alpha );

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -43,7 +43,7 @@
* A := alpha*x*x**T + A
* @param[in] storage specifies the form of storage in the memory matrix A
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] m specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] xp specifies pointer which points to the first element of xp
* @param[in] incx specifies storage spacing between elements of xp.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -59,6 +59,8 @@ TYPED_TEST(syr2_IIT_ERS, invalid_storage)
static const char CONJ = 'n';
static const gtint_t N = 4;
// Set the dimension for row/col of A and B, depending on the value of trans.
gtint_t incx = 1;
gtint_t incy = 1;
gtint_t LDA = N;
T alpha;
testinghelpers::initone<T>( alpha );

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -43,7 +43,7 @@
* A := alpha*x*y**T + alpha*y*x**T + A,
* @param[in] storage specifies the form of storage in the memory matrix A
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] xp specifies pointer which points to the first element of xp
* @param[in] incx specifies storage spacing between elements of xp.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -45,7 +45,7 @@
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] transa specifies the form of op( A ) to be used in matrix multiplication
* @param[in] diaga specifies whether the upper or lower triangular part of the array A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap
* @param[in] lda specifies leading dimension of the matrix.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2024 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -44,7 +44,7 @@ class dtrsvEVT :
double, // alpha
gtint_t, // incx
double, // exception value for X
double, // excepton value for Y
double, // exception value for Y
gtint_t>> {}; // ld_inc
TEST_P( dtrsvEVT, API )

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -45,7 +45,7 @@
* @param[in] uploa specifies whether the upper or lower triangular part of the array A
* @param[in] transa specifies the form of op( A ) to be used in matrix multiplication
* @param[in] diaga specifies whether the upper or lower triangular part of the array A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] n specifies the number of rows of the matrix A
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap
* @param[in] lda specifies leading dimension of the matrix.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2024 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -44,7 +44,7 @@ class DISABLED_ztrsvEVT :
dcomplex, // alpha
gtint_t, // incx
dcomplex, // exception value for X
dcomplex, // excepton value for Y
dcomplex, // exception value for Y
gtint_t>> {}; // ld_inc
TEST_P( DISABLED_ztrsvEVT, API )

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -47,11 +47,11 @@
the matrix multiplication
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] m specifies the number of rows of the matrix
op( A ) and of the matrix C
* @param[in] n specifies the number of columns of the matrix
* @param[in] m specifies the number of rows of the matrix
op( A ) and of the matrix C
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C
* @param[in] k specifies the number of columns of the matrix
* @param[in] k specifies the number of columns of the matrix
op( A ) and the number of rows of the matrix op( B ).
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -54,11 +54,11 @@
the matrix multiplication.
* @param[in] packa specifies whether to reorder op( A ).
* @param[in] packb specifies whether to reorder op( B ).
* @param[in] m specifies the number of rows of the matrix
op( A ) and of the matrix C.
* @param[in] n specifies the number of columns of the matrix
* @param[in] m specifies the number of rows of the matrix
op( A ) and of the matrix C.
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C.
* @param[in] k specifies the number of columns of the matrix
* @param[in] k specifies the number of columns of the matrix
op( A ) and the number of rows of the matrix op( B ).
* @param[in] ap specifies pointer which points to the first element of ap.
* @param[in] lda specifies the leading dimension of ap.

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -51,9 +51,9 @@
the matrix multiplication
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] n specifies the number of columns of the matrix
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C
* @param[in] k specifies the number of columns of the matrix
* @param[in] k specifies the number of columns of the matrix
op( A ) and the number of rows of the matrix op( B ).
* @param[in] alpha specifies the scalar alpha.
* @param[in] ap specifies pointer which points to the first element of ap

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -50,11 +50,11 @@
* @param[in] side specifies if the hemmetric matrix A appears left or right in
the matrix multiplication
* @param[in] uplo specifies if the upper or lower triangular part of A is used
* @param[in] conja specifies the form of op( A ) to be used in
* @param[in] conja specifies the form of op( A ) to be used in
the matrix multiplication
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] m specifies the number of rows and cols of the matrix
* @param[in] m specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -48,7 +48,7 @@
the matrix multiplication
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] n specifies the number of rows and cols of the matrix
* @param[in] n specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] k specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -50,11 +50,11 @@
* @param[in] side specifies if the symmetric matrix A appears left or right in
the matrix multiplication
* @param[in] uplo specifies if the upper or lower triangular part of A is used
* @param[in] conja specifies the form of op( A ) to be used in
* @param[in] conja specifies the form of op( A ) to be used in
the matrix multiplication
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] m specifies the number of rows and cols of the matrix
* @param[in] m specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -48,7 +48,7 @@
the matrix multiplication
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] n specifies the number of rows and cols of the matrix
* @param[in] n specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] k specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2025, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -50,7 +50,7 @@
* @param[in] transa specifies the form of op( A ) to be used in
the matrix multiplication
* @param[in] diaga specifies whether upper or lower triangular part of the matrix A
* @param[in] m specifies the number of rows and cols of the matrix
* @param[in] m specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -50,7 +50,7 @@
* @param[in] diaga specifies whether upper or lower triangular part of the matrix A
* @param[in] transb specifies the form of op( B ) to be used in
the matrix multiplication
* @param[in] m specifies the number of rows and cols of the matrix
* @param[in] m specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C

View File

@@ -4,7 +4,7 @@
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.
Copyright (C) 2023 - 2026, Advanced Micro Devices, Inc. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -51,7 +51,7 @@
* @param[in] transa specifies the form of op( A ) to be used in
the matrix multiplication
* @param[in] diaga specifies whether upper or lower triangular part of the matrix A
* @param[in] m specifies the number of rows and cols of the matrix
* @param[in] m specifies the number of rows and cols of the matrix
op( A ) and rows of the matrix C and B
* @param[in] n specifies the number of columns of the matrix
op( B ) and the number of columns of the matrix C