mirror of
https://github.com/amd/blis.git
synced 2026-04-19 15:18:52 +00:00
73911d5990
- The current build systems have the following behaviour
with regards to building "aocl_gemm" addon codebase(LPGEMM)
when giving "amdzen" as the target architecture(fat-binary)
- Make: Attempts to compile LPGEMM kernels using the same
compiler flags that the makefile fragments set for BLIS
kernels, based on the compiler version.
- CMake: With presets, it always enables the addon compilation
unless explicitly specified with the ENABLE_ADDON variable.
- This poses a bug with older compilers, owing to them not supporting
BF16 or INT8 intrinsic compilation.
- This patch adds the functionality to check for GCC and Clang compiler versions,
and disables LPGEMM compilation if GCC < 11.2 or Clang < 12.0.
- Make: Updated the configure script to check for the compiler version
if the addon is specified.
CMake: Updated the main CMakeLists.txt to check for the compiler version
if the addon is specified, and to also force-update the associated
cache variable update. Also updated kernels/CMakeLists.txt to
check if "aocl_gemm" remains in the ENABLE_ADDONS list after
all the checks in the previous layers.
AMD-Internal: [CPUPL-7850]
Signed-off by : Vignesh Balasubramanian <Vignesh.Balasubramanian@amd.com>
237 lines
12 KiB
CMake
237 lines
12 KiB
CMake
#[=[
|
|
|
|
BLIS
|
|
An object-based framework for developing high-performance BLAS-like
|
|
libraries.
|
|
|
|
Copyright (C) 2023 - 2025, Advanced Micro Devices, Inc. All rights reserved.
|
|
|
|
Redistribution and use in source and binary forms, with or without
|
|
modification, are permitted provided that the following conditions are
|
|
met:
|
|
- Redistributions of source code must retain the above copyright
|
|
notice, this list of conditions and the following disclaimer.
|
|
- Redistributions in binary form must reproduce the above copyright
|
|
notice, this list of conditions and the following disclaimer in the
|
|
documentation and/or other materials provided with the distribution.
|
|
- Neither the name(s) of the copyright holder(s) nor the names of its
|
|
contributors may be used to endorse or promote products derived
|
|
from this software without specific prior written permission.
|
|
|
|
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
]=]
|
|
|
|
# Writing a function that will be used to generate the required object
|
|
# libraries for the required addons.
|
|
function(generate_addon_targets addon_target)
|
|
# Collect all subdirectory paths that have at least one file with suffix in ADDON_C99_SUFS list.
|
|
get_filepaths_with_suffixes(LOCAL_SOURCE_C99_FILES "${CMAKE_CURRENT_SOURCE_DIR}/${addon_target}" "${ADDON_C99_SUFS}")
|
|
# We want to break the files above in 2 categories, files in kernel directory and the rest.
|
|
# Only list files in kernel directory.
|
|
set(LOCAL_KERNEL_FILES_C99 ${LOCAL_SOURCE_FILES})
|
|
list(FILTER LOCAL_KERNEL_FILES_C99 INCLUDE REGEX ${addon_target}/kernels/)
|
|
# All C99 files, except of the ones in kernels directory.
|
|
list(REMOVE_ITEM LOCAL_SOURCE_C99_FILES ${LOCAL_KERNEL_FILES_C99})
|
|
|
|
# Collect all subdirectory paths that have at least one file with suffix in ADDON_H99_SUFS list.
|
|
get_dirpaths_with_suffixes(CADDONINCFLAGS "${CMAKE_CURRENT_SOURCE_DIR}/${addon_target}" "${ADDON_H99_SUFS}")
|
|
|
|
# Only generate the object library if there is at least one source file.
|
|
list(LENGTH LOCAL_SOURCE_C99_FILES size)
|
|
if(size GREATER 0)
|
|
# Create an object library using the source file list above.
|
|
add_library(${addon_target}_C99_ADDON
|
|
OBJECT
|
|
${LOCAL_SOURCE_C99_FILES}
|
|
)
|
|
# Include the corresponding make_defs.cmake that holds the required compiler options.
|
|
include(${PROJECT_SOURCE_DIR}/config/${BLIS_CONFIG_FAMILY}/make_defs.cmake)
|
|
# Use PRIVATE keyword for option setting since we do not want the properties to propagate in other targets.
|
|
# mimicing get-addon-c99flags-for
|
|
target_compile_options(${addon_target}_C99_ADDON
|
|
PRIVATE
|
|
# load-var-for,COPTFLAGS
|
|
${COPTFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CDBGFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CWARNFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CMISCFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CLANGFLAGS}
|
|
# in get-addon-c99flags-for
|
|
${BUILD_SYMFLAGS}
|
|
)
|
|
target_compile_definitions(${addon_target}_C99_ADDON
|
|
PRIVATE
|
|
# in get-noopt-cflags-for
|
|
${CPPROCFLAGS}
|
|
# in get-noopt-cflags-for
|
|
${VERS_DEF}
|
|
# in get-addon-c99flags-for
|
|
${BUILD_CPPFLAGS}
|
|
)
|
|
target_include_directories(${addon_target}_C99_ADDON
|
|
BEFORE
|
|
PRIVATE
|
|
# in get-noopt-cflags-for
|
|
${CINFLAGS}
|
|
# in get-addon-c99flags-for
|
|
${CADDONINCFLAGS}
|
|
)
|
|
|
|
if(THREADING_MODEL STREQUAL "openmp")
|
|
# Equivalent to CTHREADFLAGS in get-noopt-cflags-for
|
|
target_link_libraries(${addon_target}_C99_ADDON PRIVATE OpenMP::OpenMP_C)
|
|
elseif(THREADING_MODEL STREQUAL "pthreads")
|
|
# in get-noopt-cflags-for
|
|
target_compile_options(${addon_target}_C99_ADDON PRIVATE ${CTHREADFLAGS})
|
|
endif()
|
|
# Equivalent to CPICFLAGS in get-noopt-cflags-for
|
|
set_target_properties(${addon_target}_C99_ADDON PROPERTIES POSITION_INDEPENDENT_CODE ON)
|
|
add_dependencies(${addon_target}_C99_ADDON flat-header)
|
|
# Put all those targets under object-libs-targets folder name so that they appear all together in IDE.
|
|
set_target_properties(${addon_target}_C99_ADDON PROPERTIES FOLDER object-libs-targets)
|
|
endif()
|
|
|
|
# Only generate the object library if there is at least one source file.
|
|
list(LENGTH LOCAL_KERNEL_FILES_C99 size)
|
|
if(size GREATER 0)
|
|
# Create an object library using the kernel source file list above.
|
|
add_library(${addon_target}_C99_KERNEL_ADDON
|
|
OBJECT
|
|
${LOCAL_KERNEL_FILES_C99}
|
|
)
|
|
# Include the corresponding make_defs.cmake that holds the required compiler options.
|
|
include(${PROJECT_SOURCE_DIR}/config/${BLIS_CONFIG_FAMILY}/make_defs.cmake)
|
|
# Use PRIVATE keyword for option setting since we do not want the properties to propagate in other targets.
|
|
# mimicing get-addon-c99flags-for
|
|
target_compile_options(${addon_target}_C99_KERNEL_ADDON
|
|
PRIVATE
|
|
# load-var-for,CKOPTFLAGS
|
|
${CKOPTFLAGS}
|
|
# load-var-for,CKVECFLAGS
|
|
${CKVECFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CDBGFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CWARNFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CMISCFLAGS}
|
|
# get-noopt-cflags-for
|
|
${CLANGFLAGS}
|
|
# in get-addon-kernel-c99flags-for
|
|
${BUILD_SYMFLAGS}
|
|
)
|
|
target_compile_definitions(${addon_target}_C99_KERNEL_ADDON
|
|
PRIVATE
|
|
# in get-noopt-cflags-for
|
|
${CPPROCFLAGS}
|
|
# in get-noopt-cflags-for
|
|
${VERS_DEF}
|
|
# in get-addon-kernel-c99flags-for
|
|
${BUILD_CPPFLAGS}
|
|
)
|
|
target_include_directories(${addon_target}_C99_KERNEL_ADDON
|
|
BEFORE
|
|
PRIVATE
|
|
# in get-noopt-cflags-for
|
|
${CINFLAGS}
|
|
# in get-addon-kernel-c99flags-for
|
|
${CADDONINCFLAGS}
|
|
)
|
|
if(THREADING_MODEL STREQUAL "openmp")
|
|
# Equivalent to CTHREADFLAGS in get-noopt-cflags-for
|
|
target_link_libraries(${addon_target}_C99_KERNEL_ADDON PRIVATE OpenMP::OpenMP_C)
|
|
elseif(THREADING_MODEL STREQUAL "pthreads")
|
|
# in get-noopt-cflags-for
|
|
target_compile_options(${addon_target}_C99_KERNEL_ADDON PRIVATE ${CTHREADFLAGS})
|
|
endif()
|
|
# Equivalent to CPICFLAGS in get-noopt-cflags-for
|
|
set_target_properties(${addon_target}_C99_KERNEL_ADDON PROPERTIES POSITION_INDEPENDENT_CODE ON)
|
|
add_dependencies(${addon_target}_C99_KERNEL_ADDON flat-header)
|
|
# Put all those targets under object-libs-targets folder name so that they appear all together in IDE.
|
|
set_target_properties(${addon_target}_C99_KERNEL_ADDON PROPERTIES FOLDER object-libs-targets)
|
|
endif()
|
|
|
|
# Note: C++ files (JIT code) are not collected here.
|
|
# The main CMakeLists.txt already filters out aocl_gemm addon for compilers
|
|
# that don't support BF16 intrinsics (GCC < 11.2, Clang < 12.0).
|
|
# For supported compilers, we only use C files with intrinsics, not JIT.
|
|
set(LOCAL_SOURCE_CXX_FILES "")
|
|
|
|
# Only generate the object library if there is at least one source file.
|
|
list(LENGTH LOCAL_SOURCE_CXX_FILES size)
|
|
if(size GREATER 0)
|
|
# Create an object library using the source file list above.
|
|
add_library(${addon_target}_CXX_ADDON
|
|
OBJECT
|
|
${LOCAL_SOURCE_CXX_FILES}
|
|
)
|
|
|
|
# Use PRIVATE keyword for option setting since we do not want the properties to propagate in other targets.
|
|
# mimicing get-addon-cxxflags-for
|
|
target_compile_options(${addon_target}_CXX_ADDON
|
|
PRIVATE
|
|
# load-var-for,COPTFLAGS
|
|
${COPTFLAGS}
|
|
# get-noopt-cxxflags-for
|
|
${CDBGFLAGS}
|
|
# get-noopt-cxxflags-for
|
|
${CWARNFLAGS}
|
|
# get-noopt-cxxflags-for
|
|
${CMISCFLAGS}
|
|
# get-noopt-cxxflags-for
|
|
${CXXLANGFLAGS}
|
|
# in get-addon-cxxflags-for
|
|
${BUILD_SYMFLAGS}
|
|
)
|
|
target_compile_definitions(${addon_target}_CXX_ADDON
|
|
PRIVATE
|
|
# in get-noopt-cflags-for
|
|
${CPPROCFLAGS}
|
|
# in get-noopt-cflags-for
|
|
${VERS_DEF}
|
|
# in get-addon-cxxflags-for
|
|
${BUILD_CPPFLAGS}
|
|
)
|
|
target_include_directories(${addon_target}_CXX_ADDON
|
|
BEFORE
|
|
PRIVATE
|
|
# in get-noopt-cflags-for
|
|
${CINFLAGS}
|
|
# in get-addon-cxxflags-for
|
|
${CADDONINCFLAGS}
|
|
)
|
|
if(THREADING_MODEL STREQUAL "openmp")
|
|
# Equivalent to CTHREADFLAGS in get-noopt-cflags-for
|
|
target_link_libraries(${addon_target}_CXX_ADDON PRIVATE OpenMP::OpenMP_C)
|
|
elseif(THREADING_MODEL STREQUAL "pthreads")
|
|
# in get-noopt-cflags-for
|
|
target_compile_options(${addon_target}_CXX_ADDON PRIVATE ${CTHREADFLAGS})
|
|
endif()
|
|
# Equivalent to CPICFLAGS in get-noopt-cflags-for
|
|
set_target_properties(${addon_target}_CXX_ADDON PROPERTIES POSITION_INDEPENDENT_CODE ON)
|
|
add_dependencies(${addon_target}_CXX_ADDON flat-header)
|
|
# Put all those targets under object-libs-targets folder name so that they appear all together in IDE.
|
|
set_target_properties(${addon_target}_CXX_ADDON PROPERTIES FOLDER object-libs-targets)
|
|
endif()
|
|
endfunction()
|
|
|
|
# Generate targets for each of the addons.
|
|
foreach(ADDON ${ENABLE_ADDON})
|
|
generate_addon_targets(${ADDON})
|
|
endforeach()
|