[PR #328] [MERGED] added close button when drawer shown in the topright corner #1750

New issue

Closed

opened 2026-10-13 20:47:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 20:47:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/328
Author: @ronoaer
Created: 9/16/2023
Status: ✅ Merged
Merged: 9/18/2023
Merged by: @Nethius

Base: feature/new-gui ← Head: bugfix/add_top_close_button

📝 Commits (3)

8a3bdf1 added close button when drawer shown in the topright corner
8965b1f fixed the size of the drawer close button
ad236ba fixed a typo in the variable name

📊 Changes

7 files changed (+118 additions, -0 deletions)

View changed files

📝 client/resources.qrc (+1 -0)
📝 client/ui/controllers/pageController.cpp (+30 -0)
📝 client/ui/controllers/pageController.h (+11 -0)
📝 client/ui/qml/Controls2/DrawerType.qml (+20 -0)
➕ client/ui/qml/Controls2/TopCloseButtonType.qml (+30 -0)
📝 client/ui/qml/Pages2/PageShare.qml (+6 -0)
📝 client/ui/qml/Pages2/PageStart.qml (+20 -0)

📄 Description

show it when open a drawer, and property needCloseButton is true
close all of drawers when click top-close-button
it will be invisible when there is not drawers
todo: it needs be refectory-ed to a single Controller, separated from page-controller

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/328 **Author:** [@ronoaer](https://github.com/ronoaer) **Created:** 9/16/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@Nethius](https://github.com/Nethius) **Base:** `feature/new-gui` ← **Head:** `bugfix/add_top_close_button` --- ### 📝 Commits (3) - [`8a3bdf1`](https://github.com/amnezia-vpn/amnezia-client/commit/8a3bdf136bb8e0d30f9d3e363b987ca98b0a313f) added close button when drawer shown in the topright corner - [`8965b1f`](https://github.com/amnezia-vpn/amnezia-client/commit/8965b1fbba6debeb53195c1791e83490d5c353bb) fixed the size of the drawer close button - [`ad236ba`](https://github.com/amnezia-vpn/amnezia-client/commit/ad236baa8686b12f7330df52a8cea4ecb9ef620b) fixed a typo in the variable name ### 📊 Changes **7 files changed** (+118 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/resources.qrc` (+1 -0) 📝 `client/ui/controllers/pageController.cpp` (+30 -0) 📝 `client/ui/controllers/pageController.h` (+11 -0) 📝 `client/ui/qml/Controls2/DrawerType.qml` (+20 -0) ➕ `client/ui/qml/Controls2/TopCloseButtonType.qml` (+30 -0) 📝 `client/ui/qml/Pages2/PageShare.qml` (+6 -0) 📝 `client/ui/qml/Pages2/PageStart.qml` (+20 -0) </details> ### 📄 Description 1. show it when open a drawer, and property needCloseButton is true 2. close all of drawers when click top-close-button 3. it will be invisible when there is not drawers 4. todo: it needs be refectory-ed to a single Controller, separated from page-controller --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 20:47:42 +00:00