[PR #38] Refactor: Use unified app group identifier build configuration setting. #38

New issue

Open

opened 2026-10-13 21:08:49 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 21:08:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amneziawg-apple/pull/38
Author: @lolgear
Created: 7/28/2026
Status: 🔄 Open

Base: master ← Head: refactor/use_unified_app_group_identifier_config_setting

📝 Commits (1)

b7b7bea refactor: use unified app group identifier configuration setting.

📊 Changes

9 files changed (+37 additions, -38 deletions)

View changed files

📝 Sources/WireGuardApp/Config/Config.xcconfig (+4 -1)
📝 Sources/WireGuardApp/UI/iOS/Info.plist (+8 -9)
📝 Sources/WireGuardApp/UI/macOS/Info.plist (+7 -8)
📝 Sources/WireGuardApp/UI/macOS/LoginItemHelper/Info.plist (+6 -7)
📝 Sources/WireGuardApp/UI/macOS/LoginItemHelper/LoginItemHelper.entitlements (+1 -1)
📝 Sources/WireGuardApp/UI/macOS/WireGuard.entitlements (+1 -1)
📝 Sources/WireGuardNetworkExtension/Info.plist (+8 -9)
📝 Sources/WireGuardNetworkExtension/WireGuardNetworkExtension_iOS.entitlements (+1 -1)
📝 Sources/WireGuardNetworkExtension/WireGuardNetworkExtension_macOS.entitlements (+1 -1)

📄 Description

📝 What was done

This PR refactors how the App Group Identifier is managed. Instead of hardcoding the ID or scattering it across different files, everything is now moved into a single, unified build configuration setting.
Both the main app and the network extension now pull the identical App Group ID automatically. This fixes configuration clutter and makes it much easier to rebrand or use custom identifiers for AmneziaWG builds.

⚙️ Key Changes

Moved the App Group ID into a shared build configuration variable.
Updated .entitlements files to resolve the group identifier dynamically.
Refactored shared container initialization code in both the main app and the tunnel target to use this new unified setting.
Cleaned up old hardcoded string constants.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amneziawg-apple/pull/38 **Author:** [@lolgear](https://github.com/lolgear) **Created:** 7/28/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `refactor/use_unified_app_group_identifier_config_setting` --- ### 📝 Commits (1) - [`b7b7bea`](https://github.com/amnezia-vpn/amneziawg-apple/commit/b7b7beaeaae8349d8262e1aa651c4d30aecaf672) refactor: use unified app group identifier configuration setting. ### 📊 Changes **9 files changed** (+37 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `Sources/WireGuardApp/Config/Config.xcconfig` (+4 -1) 📝 `Sources/WireGuardApp/UI/iOS/Info.plist` (+8 -9) 📝 `Sources/WireGuardApp/UI/macOS/Info.plist` (+7 -8) 📝 `Sources/WireGuardApp/UI/macOS/LoginItemHelper/Info.plist` (+6 -7) 📝 `Sources/WireGuardApp/UI/macOS/LoginItemHelper/LoginItemHelper.entitlements` (+1 -1) 📝 `Sources/WireGuardApp/UI/macOS/WireGuard.entitlements` (+1 -1) 📝 `Sources/WireGuardNetworkExtension/Info.plist` (+8 -9) 📝 `Sources/WireGuardNetworkExtension/WireGuardNetworkExtension_iOS.entitlements` (+1 -1) 📝 `Sources/WireGuardNetworkExtension/WireGuardNetworkExtension_macOS.entitlements` (+1 -1) </details> ### 📄 Description ## 📝 What was done This PR refactors how the App Group Identifier is managed. Instead of hardcoding the ID or scattering it across different files, everything is now moved into a single, unified build configuration setting. Both the main app and the network extension now pull the identical App Group ID automatically. This fixes configuration clutter and makes it much easier to rebrand or use custom identifiers for AmneziaWG builds. ## ⚙️ Key Changes * Moved the App Group ID into a shared build configuration variable. * Updated .entitlements files to resolve the group identifier dynamically. * Refactored shared container initialization code in both the main app and the tunnel target to use this new unified setting. * Cleaned up old hardcoded string constants. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-13 21:08:49 +00:00

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amneziawg-apple#38

No description provided.

Rows
Columns