[PR #40] [MERGED] [ROCm][Windows] revert reduced VRAM_CHUNK_SIZE #80

New issue

Closed

opened 2026-10-26 22:24:23 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:24:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-aimdo/pull/40
Author: @Apophis3158
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/28/2026
Merged by: @rattus128

Base: master ← Head: dev/win-vram_chunk

📝 Commits (1)

188cf7d [ROCm][Windows] revert reduced VRAM_CHUNK_SIZE

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src-win/cuda-detour.c (+2 -2)
📝 src/vrambuf.c (+1 -1)

📄 Description

Contribution Agreement

I agree that my contributions are licensed under the GPLv3.
I grant Comfy Org the rights to relicense these contributions as outlined in CONTRIBUTING.md.

On ROCm Windows, setting VRAM_CHUNK_SIZE to 16MB like CUDA works fine, and I've been using it this way for two months.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-aimdo/pull/40 **Author:** [@Apophis3158](https://github.com/Apophis3158) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/28/2026 **Merged by:** [@rattus128](https://github.com/rattus128) **Base:** `master` ← **Head:** `dev/win-vram_chunk` --- ### 📝 Commits (1) - [`188cf7d`](https://github.com/Comfy-Org/comfy-aimdo/commit/188cf7ddf2ab1e12a986e66a4cf23063e50b6ff6) [ROCm][Windows] revert reduced VRAM_CHUNK_SIZE ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src-win/cuda-detour.c` (+2 -2) 📝 `src/vrambuf.c` (+1 -1) </details> ### 📄 Description ### Contribution Agreement - [x] I agree that my contributions are licensed under the GPLv3. - [x] I grant **Comfy Org** the rights to relicense these contributions as outlined in [CONTRIBUTING.md](./CONTRIBUTING.md). ### On ROCm Windows, setting `VRAM_CHUNK_SIZE` to 16MB like CUDA works fine, and I've been using it this way for two months. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:24:23 +00:00