[PR #66] [MERGED] Allow passing output tensor in low_latency_combine #428

Closed
opened 2026-10-26 10:00:38 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/66
Author: @dzhulgakov
Created: 3/10/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @LyricZhao

Base: main ← Head: combine-out-arg


📝 Commits (2)

  • b3b61ef Allow passing output tensor in low_latency_combine
  • 50ac280 comments

📊 Changes

4 files changed (+17 additions, -6 deletions)

View changed files

📝 csrc/deep_ep.cpp (+10 -2)
📝 csrc/deep_ep.hpp (+1 -1)
📝 deep_ep/buffer.py (+4 -2)
📝 tests/test_low_latency.py (+2 -1)

📄 Description

It's convenient for explicit buffer management in some situations. The convention with optional out= arguments matches PyTorch common practices.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/66 **Author:** [@dzhulgakov](https://github.com/dzhulgakov) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@LyricZhao](https://github.com/LyricZhao) **Base:** `main` ← **Head:** `combine-out-arg` --- ### 📝 Commits (2) - [`b3b61ef`](https://github.com/deepseek-ai/DeepEP/commit/b3b61ef5efe4d9a13c455bdf770f4a8e9c91df4a) Allow passing output tensor in low_latency_combine - [`50ac280`](https://github.com/deepseek-ai/DeepEP/commit/50ac280ae7028ddda73ef6107dcb6bae23c5815f) comments ### 📊 Changes **4 files changed** (+17 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `csrc/deep_ep.cpp` (+10 -2) 📝 `csrc/deep_ep.hpp` (+1 -1) 📝 `deep_ep/buffer.py` (+4 -2) 📝 `tests/test_low_latency.py` (+2 -1) </details> ### 📄 Description It's convenient for explicit buffer management in some situations. The convention with optional `out=` arguments matches PyTorch common practices. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 10:00:38 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepEP#428
No description provided.