[PR #282] add caller location for util functions for better error message #341

Open
opened 2026-10-26 21:16:27 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepGEMM/pull/282
Author: @YouJiacheng
Created: 1/20/2026
Status: 🔄 Open

Base: main ← Head: caller-location-util-assert


📝 Commits (1)

  • dc13359 chore: add caller location for util functions for better error message

📊 Changes

3 files changed (+39 additions, -31 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)
📝 csrc/utils/exception.hpp (+9 -3)
📝 csrc/utils/layout.hpp (+28 -26)

📄 Description

https://github.com/vllm-project/vllm/issues/32647

RuntimeError: Assertion error (csrc/apis/../jit_kernels/impls/../heuristics/../../utils/layout.hpp:39): t.dim() == N error like this is uninformative. this draft improves the error message by adding source location of caller of these util functions.

passing location might have performance penalty if compiler doesn't optimize it.

stacktrace libraries will need DWARF debug info to print line number, and they also need addr2line/libbfd or custom parsing logics to work.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepGEMM/pull/282 **Author:** [@YouJiacheng](https://github.com/YouJiacheng) **Created:** 1/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `caller-location-util-assert` --- ### 📝 Commits (1) - [`dc13359`](https://github.com/deepseek-ai/DeepGEMM/commit/dc1335948f248afc0deffb9cd59e7db28ab34431) chore: add caller location for util functions for better error message ### 📊 Changes **3 files changed** (+39 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) 📝 `csrc/utils/exception.hpp` (+9 -3) 📝 `csrc/utils/layout.hpp` (+28 -26) </details> ### 📄 Description https://github.com/vllm-project/vllm/issues/32647 `RuntimeError: Assertion error (csrc/apis/../jit_kernels/impls/../heuristics/../../utils/layout.hpp:39): t.dim() == N` error like this is uninformative. this draft improves the error message by adding source location of caller of these util functions. passing location might have performance penalty if compiler doesn't optimize it. stacktrace libraries will need DWARF debug info to print line number, and they also need addr2line/libbfd or custom parsing logics to work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepGEMM#341
No description provided.