[PR #32] [MERGED] fix: avoid duplicate container IP allocation #34

New issue

Closed

opened 2026-10-15 12:51:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/32
Author: @JBailes
Created: 5/17/2026
Status: ✅ Merged
Merged: 5/17/2026
Merged by: @JBailes

Base: main ← Head: fix/avoid-duplicate-container-ips

📝 Commits (1)

70fc972 fix: avoid duplicate container IP allocation

📊 Changes

2 files changed (+208 additions, -71 deletions)

View changed files

📝 internal/store/store.go (+125 -68)
📝 internal/store/store_test.go (+83 -3)

📄 Description

Summary

skip free-list IPs that are still assigned to existing container records
skip in-use addresses when advancing the managed 10.100.0.0/24 counter
avoid returning an address to the free-list while another record still uses it

Validation

go test ./internal/store
go test ./... currently cannot run locally because liblxc/pkg-config is not installed in this environment

Live SmoothNAS diagnosis showed the controller and two GitHub runner workers all reported 10.100.0.3, so stale free-list entries can break DNS and outbound GitHub broker connectivity.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/32 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/17/2026 **Status:** ✅ Merged **Merged:** 5/17/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/avoid-duplicate-container-ips` --- ### 📝 Commits (1) - [`70fc972`](https://github.com/games-on-whales/LXC2Docker/commit/70fc972f1b8b56bb35c90fbc7c6116a89e221d74) fix: avoid duplicate container IP allocation ### 📊 Changes **2 files changed** (+208 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `internal/store/store.go` (+125 -68) 📝 `internal/store/store_test.go` (+83 -3) </details> ### 📄 Description ## Summary - skip free-list IPs that are still assigned to existing container records - skip in-use addresses when advancing the managed 10.100.0.0/24 counter - avoid returning an address to the free-list while another record still uses it ## Validation - go test ./internal/store - go test ./... currently cannot run locally because liblxc/pkg-config is not installed in this environment Live SmoothNAS diagnosis showed the controller and two GitHub runner workers all reported 10.100.0.3, so stale free-list entries can break DNS and outbound GitHub broker connectivity. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:29 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

games-on-whales/LXC2Docker#34

No description provided.

Rows
Columns