[PR #31] [MERGED] fix: stop forcing tcp for container dns #32

Closed
opened 2026-10-15 12:51:27 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/31
Author: @JBailes
Created: 5/17/2026
Status: ✅ Merged
Merged: 5/17/2026
Merged by: @JBailes

Base: main ← Head: fix/container-dns-no-tcp


📝 Commits (1)

  • c4c894f fix: stop forcing tcp for container dns

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 internal/lxc/manager.go (+1 -1)
📝 internal/lxc/manager_test.go (+2 -2)

📄 Description

Summary

  • remove use-vc from generated container resolv.conf options
  • keep bounded resolver timeouts and rotation across host/fallback nameservers

Test plan

  • attempted: go test ./internal/lxc
  • blocked locally: missing liblxc pkg-config dependency (lxc.pc)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/31 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/17/2026 **Status:** ✅ Merged **Merged:** 5/17/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/container-dns-no-tcp` --- ### 📝 Commits (1) - [`c4c894f`](https://github.com/games-on-whales/LXC2Docker/commit/c4c894fc2d11c9747145050c06e042c1fed1a0d7) fix: stop forcing tcp for container dns ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/lxc/manager.go` (+1 -1) 📝 `internal/lxc/manager_test.go` (+2 -2) </details> ### 📄 Description ## Summary - remove use-vc from generated container resolv.conf options - keep bounded resolver timeouts and rotation across host/fallback nameservers ## Test plan - attempted: go test ./internal/lxc - blocked locally: missing liblxc pkg-config dependency (lxc.pc) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 12:51:27 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/LXC2Docker#32
No description provided.