[PR #30] [MERGED] fix: add fallback DNS servers for containers #31

New issue

Closed

opened 2026-10-15 12:51:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/30
Author: @JBailes
Created: 5/17/2026
Status: ✅ Merged
Merged: 5/17/2026
Merged by: @JBailes

Base: main ← Head: fix/dns-public-fallback

📝 Commits (1)

30fc887 fix: add fallback DNS servers for containers

📊 Changes

2 files changed (+21 additions, -3 deletions)

View changed files

📝 internal/lxc/manager.go (+19 -1)
📝 internal/lxc/manager_test.go (+2 -2)

📄 Description

Summary

keep host DNS servers first in generated container resolv.conf
append public fallback resolvers when host DNS is present but unreachable from the LXC bridge
preserve explicit Docker DNS config unchanged

Tests

go test ./internal/lxc (fails locally: pkg-config cannot find lxc.pc)
live SmoothNAS runner container resolved api.github.com with host DNS + fallback resolvers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/30 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/17/2026 **Status:** ✅ Merged **Merged:** 5/17/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/dns-public-fallback` --- ### 📝 Commits (1) - [`30fc887`](https://github.com/games-on-whales/LXC2Docker/commit/30fc88703383a102c5f0862daeee69002f9c49bf) fix: add fallback DNS servers for containers ### 📊 Changes **2 files changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/lxc/manager.go` (+19 -1) 📝 `internal/lxc/manager_test.go` (+2 -2) </details> ### 📄 Description ## Summary - keep host DNS servers first in generated container resolv.conf - append public fallback resolvers when host DNS is present but unreachable from the LXC bridge - preserve explicit Docker DNS config unchanged ## Tests - go test ./internal/lxc *(fails locally: pkg-config cannot find lxc.pc)* - live SmoothNAS runner container resolved api.github.com with host DNS + fallback resolvers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:26 +00:00