[PR #36] [MERGED] fix: make Docker CLI tests portable #37

New issue

Closed

opened 2026-10-15 12:51:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/36
Author: @JBailes
Created: 5/21/2026
Status: ✅ Merged
Merged: 5/21/2026
Merged by: @JBailes

Base: main ← Head: fix/docker-cli-test-compat

📝 Commits (1)

7ff436e fix: make docker cli tests portable

📊 Changes

7 files changed (+68 additions, -83 deletions)

View changed files

📝 Makefile (+1 -16)
📝 go.mod (+0 -1)
📝 go.sum (+0 -2)
📝 internal/lxc/config.go (+14 -5)
📝 internal/lxc/config_test.go (+4 -7)
📝 internal/lxc/manager.go (+48 -51)
📝 readme.md (+1 -1)

📄 Description

Summary

remove the native go-lxc/liblxc link dependency from LXC manager code
use LXC CLI operations for template creation/cloning and app-template setup
make raw socket mount tests independent of host socket permissions
update build docs and Makefile now that tests do not need native liblxc linking

Verification

aimee git verify
env GOCACHE=/tmp/lxc2docker-go-build make test
env GOCACHE=/tmp/lxc2docker-go-build make build
SUSE docker-cli unit package set with writable HOME and host socket/network access

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/36 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/21/2026 **Status:** ✅ Merged **Merged:** 5/21/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/docker-cli-test-compat` --- ### 📝 Commits (1) - [`7ff436e`](https://github.com/games-on-whales/LXC2Docker/commit/7ff436e2ef1536e375dc789abaea282b906edb64) fix: make docker cli tests portable ### 📊 Changes **7 files changed** (+68 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -16) 📝 `go.mod` (+0 -1) 📝 `go.sum` (+0 -2) 📝 `internal/lxc/config.go` (+14 -5) 📝 `internal/lxc/config_test.go` (+4 -7) 📝 `internal/lxc/manager.go` (+48 -51) 📝 `readme.md` (+1 -1) </details> ### 📄 Description ## Summary - remove the native go-lxc/liblxc link dependency from LXC manager code - use LXC CLI operations for template creation/cloning and app-template setup - make raw socket mount tests independent of host socket permissions - update build docs and Makefile now that tests do not need native liblxc linking ## Verification - aimee git verify - env GOCACHE=/tmp/lxc2docker-go-build make test - env GOCACHE=/tmp/lxc2docker-go-build make build - SUSE docker-cli unit package set with writable HOME and host socket/network access --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:30 +00:00