[PR #35] [MERGED] fix: rewrite raw socket mounts #36

New issue

Closed

opened 2026-10-15 12:51:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/35
Author: @JBailes
Created: 5/18/2026
Status: ✅ Merged
Merged: 5/18/2026
Merged by: @JBailes

Base: main ← Head: fix/raw-socket-mounts

📝 Commits (1)

645e6b5 fix: rewrite raw socket mounts

📊 Changes

2 files changed (+78 additions, -3 deletions)

View changed files

📝 internal/lxc/config.go (+46 -3)
📝 internal/lxc/config_test.go (+32 -0)

📄 Description

Summary

rewrite raw lxc.mount.entry Unix socket binds into parent-directory mounts plus socket symlinks
apply the same stale-socket protection to rawConfig that Docker Mounts already get
add a focused unit test for raw socket mount rewriting

Testing

go test ./internal/lxc (blocked locally: missing lxc.pc / LXC development headers)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/35 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/18/2026 **Status:** ✅ Merged **Merged:** 5/18/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/raw-socket-mounts` --- ### 📝 Commits (1) - [`645e6b5`](https://github.com/games-on-whales/LXC2Docker/commit/645e6b5792cbefcef5e72d899fe7c560dbd3e413) fix: rewrite raw socket mounts ### 📊 Changes **2 files changed** (+78 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/lxc/config.go` (+46 -3) 📝 `internal/lxc/config_test.go` (+32 -0) </details> ### 📄 Description ## Summary - rewrite raw lxc.mount.entry Unix socket binds into parent-directory mounts plus socket symlinks - apply the same stale-socket protection to rawConfig that Docker Mounts already get - add a focused unit test for raw socket mount rewriting ## Testing - go test ./internal/lxc (blocked locally: missing lxc.pc / LXC development headers) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:29 +00:00