[PR #33] [MERGED] fix: upstream SmoothNAS runtime patch behavior #35

New issue

Closed

opened 2026-10-15 12:51:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/33
Author: @JBailes
Created: 5/17/2026
Status: ✅ Merged
Merged: 5/17/2026
Merged by: @JBailes

Base: main ← Head: fix/cap-oci-template-names

📝 Commits (2)

8dad515 fix: cap OCI template names
b1da844 fix: reattach legacy lxc veth to bridge

📊 Changes

4 files changed (+120 additions, -2 deletions)

View changed files

📝 internal/image/resolver.go (+29 -1)
📝 internal/image/resolver_test.go (+16 -1)
📝 internal/lxc/manager.go (+58 -0)
📝 internal/lxc/manager_test.go (+17 -0)

📄 Description

Summary

cap OCI template container names to the Linux hostname limit with a stable hash suffix
reattach legacy LXC host veth devices to the managed bridge after start and during reconcile
add coverage for OCI template-name length and parsing the host veth link from lxc-info

Validation

go test ./internal/image
go test ./internal/lxc cannot run locally because liblxc/pkg-config is not installed in this environment

This upstreams the remaining behavior SmoothNAS was carrying as local LXC2Docker patches so SmoothNAS can build directly from LXC2Docker main without patching.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/33 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/17/2026 **Status:** ✅ Merged **Merged:** 5/17/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/cap-oci-template-names` --- ### 📝 Commits (2) - [`8dad515`](https://github.com/games-on-whales/LXC2Docker/commit/8dad515708d2d758f068bc419b8f3ca5e9e99108) fix: cap OCI template names - [`b1da844`](https://github.com/games-on-whales/LXC2Docker/commit/b1da8448f0e4db27162748ca2de4991904f7d98e) fix: reattach legacy lxc veth to bridge ### 📊 Changes **4 files changed** (+120 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/image/resolver.go` (+29 -1) 📝 `internal/image/resolver_test.go` (+16 -1) 📝 `internal/lxc/manager.go` (+58 -0) 📝 `internal/lxc/manager_test.go` (+17 -0) </details> ### 📄 Description ## Summary - cap OCI template container names to the Linux hostname limit with a stable hash suffix - reattach legacy LXC host veth devices to the managed bridge after start and during reconcile - add coverage for OCI template-name length and parsing the host veth link from lxc-info ## Validation - go test ./internal/image - go test ./internal/lxc cannot run locally because liblxc/pkg-config is not installed in this environment This upstreams the remaining behavior SmoothNAS was carrying as local LXC2Docker patches so SmoothNAS can build directly from LXC2Docker main without patching. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-15 12:51:29 +00:00

bsakaguchi referenced this issue

2026-10-15 12:51:29 +00:00

[PR #35] [MERGED] fix: rewrite raw socket mounts #36

bsakaguchi closed this issue

2026-10-15 12:51:29 +00:00