[PR #34] [MERGED] fix: inherit host dns and reconcile bridge nat #33

Closed
opened 2026-10-15 12:51:29 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/34
Author: @JBailes
Created: 5/18/2026
Status: ✅ Merged
Merged: 5/18/2026
Merged by: @JBailes

Base: main ← Head: fix/inherit-host-dns


📝 Commits (1)

  • 6ec1fcb fix: inherit host dns and reconcile bridge nat

📊 Changes

3 files changed (+33 additions, -18 deletions)

View changed files

📝 cmd/docker-lxc-daemon/main.go (+2 -0)
📝 internal/lxc/manager.go (+29 -16)
📝 internal/lxc/manager_test.go (+2 -2)

📄 Description

Summary

  • use host nameservers as the default container resolvers without appending public DNS
  • keep the managed bridge/NAT table reconciled after host firewall reloads
  • reassert bridge/NAT before creating or starting managed-network containers

Tests

  • go test ./internal/lxc -run 'TestBuildResolvConf|Test.*Network' (fails locally: missing lxc.pc / liblxc pkg-config metadata)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/34 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/18/2026 **Status:** ✅ Merged **Merged:** 5/18/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/inherit-host-dns` --- ### 📝 Commits (1) - [`6ec1fcb`](https://github.com/games-on-whales/LXC2Docker/commit/6ec1fcb7744e4d91a9bee63a3725a88cd62f59e1) fix: inherit host dns and reconcile bridge nat ### 📊 Changes **3 files changed** (+33 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `cmd/docker-lxc-daemon/main.go` (+2 -0) 📝 `internal/lxc/manager.go` (+29 -16) 📝 `internal/lxc/manager_test.go` (+2 -2) </details> ### 📄 Description ## Summary - use host nameservers as the default container resolvers without appending public DNS - keep the managed bridge/NAT table reconciled after host firewall reloads - reassert bridge/NAT before creating or starting managed-network containers ## Tests - go test ./internal/lxc -run 'TestBuildResolvConf|Test.*Network' *(fails locally: missing lxc.pc / liblxc pkg-config metadata)* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 12:51:29 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/LXC2Docker#33
No description provided.