[PR #11] [MERGED] Fix malformed json struct tag on RuntimeWolfVariables.RenderNode #13

New issue

Closed

opened 2026-10-15 12:46:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:46:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/fenrir/pull/11
Author: @shrinedogg
Created: 6/13/2026
Status: ✅ Merged
Merged: 6/13/2026
Merged by: @ABeltramo

Base: main ← Head: fix/rendernode-struct-tag

📝 Commits (1)

6e90c1e Fix malformed json struct tag on RuntimeWolfVariables.RenderNode

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkg/api/v1alpha1/app.go (+1 -1)

📄 Description

Problem

The RenderNode field on RuntimeWolfVariables has a malformed struct tag — there's a stray trailing double quote:

RenderNode string `json:"renderNode,omitempty""`

go vet flags it:

pkg/api/v1alpha1/app.go:67:2: struct field tag `json:"renderNode,omitempty""` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces

Because reflect.StructTag.Get cannot parse the tag, any tag lookup for this field is unreliable, and go vet fails (breaking vet-gated CI).

Fix

Drop the extra quote: json:"renderNode,omitempty".

Testing

go vet ./pkg/api/v1alpha1/ is now clean and the package builds.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/fenrir/pull/11 **Author:** [@shrinedogg](https://github.com/shrinedogg) **Created:** 6/13/2026 **Status:** ✅ Merged **Merged:** 6/13/2026 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `main` ← **Head:** `fix/rendernode-struct-tag` --- ### 📝 Commits (1) - [`6e90c1e`](https://github.com/games-on-whales/fenrir/commit/6e90c1ee963d18396890c76840a2dbe5ef87e1ae) Fix malformed json struct tag on RuntimeWolfVariables.RenderNode ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/api/v1alpha1/app.go` (+1 -1) </details> ### 📄 Description ## Problem The `RenderNode` field on `RuntimeWolfVariables` has a malformed struct tag — there's a stray trailing double quote: ```go RenderNode string `json:"renderNode,omitempty""` ``` `go vet` flags it: ``` pkg/api/v1alpha1/app.go:67:2: struct field tag `json:"renderNode,omitempty""` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces ``` Because `reflect.StructTag.Get` cannot parse the tag, any tag lookup for this field is unreliable, and `go vet` fails (breaking `vet`-gated CI). ## Fix * Drop the extra quote: `json:"renderNode,omitempty"`. ## Testing * `go vet ./pkg/api/v1alpha1/` is now clean and the package builds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:46:39 +00:00