[PR #13] [MERGED] Update the CI workflows to include linting and tests #14

New issue

Closed

opened 2026-10-15 12:46:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:46:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/fenrir/pull/13
Author: @axolotlite
Created: 7/11/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @axolotlite

Base: main ← Head: chore/ci-workflows

📝 Commits (10+)

b0c4668 [ci] only build images on push / merge into main
b991198 [ci] add golangci-lint config and github action
cf45da1 [ci] add tests and image builds during PRs
5a39610 [ci:PR] build all 3 images even if one fails
be027b2 [ci:PR] remove the faulty tag
e71ec25 [ci] add makefile and timeout to go test
5072452 [tests] comment out config tests
170bfc3 [ci] uncomment the release logic
cf75e53 [lint] use the correct import name for fenrir
bdc3397 [crds] remove faulty quotation

📊 Changes

10 files changed (+440 additions, -102 deletions)

View changed files

➕ .github/workflows/build.yml (+37 -0)
📝 .github/workflows/builder.yml (+1 -1)
➕ .github/workflows/golangci-lint.yml (+20 -0)
➕ .github/workflows/test.yml (+36 -0)
➕ .golangci.yml (+221 -0)
➕ Makefile (+25 -0)
📝 pkg/api/v1alpha1/app.go (+2 -3)
📝 pkg/controllers/config_test.go (+36 -36)
📝 pkg/controllers/session_test.go (+4 -4)
📝 pkg/wolfapi/client_test.go (+58 -58)

📄 Description

This PR aims to add golangci-lint alongside some tests during the PR process.

I've tried to follow the example set in kubernetes-sigs/cluster-api: golangci.yml alongside a few other sigs projects.
I've commented out the pull_request from .github/workflows/builder.yml and added a new workflow .github/workflows/build.yml that just builds the images for the PR without pushing them, so that images are only built then pushed on merging to main.

I'm considering rewriting .github/workflows/builder.yml to just follow DRY and remove build.yml

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/fenrir/pull/13 **Author:** [@axolotlite](https://github.com/axolotlite) **Created:** 7/11/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@axolotlite](https://github.com/axolotlite) **Base:** `main` ← **Head:** `chore/ci-workflows` --- ### 📝 Commits (10+) - [`b0c4668`](https://github.com/games-on-whales/fenrir/commit/b0c4668db9cef8e76194084c2f4ffcac9575f166) [ci] only build images on push / merge into main - [`b991198`](https://github.com/games-on-whales/fenrir/commit/b991198e4b7c22c85c07248457341cdea325ee0c) [ci] add golangci-lint config and github action - [`cf45da1`](https://github.com/games-on-whales/fenrir/commit/cf45da1e8702af05dbc1124601fe1051f8f80524) [ci] add tests and image builds during PRs - [`5a39610`](https://github.com/games-on-whales/fenrir/commit/5a39610542af6f60f9f8d1592fc49e98361f185d) [ci:PR] build all 3 images even if one fails - [`be027b2`](https://github.com/games-on-whales/fenrir/commit/be027b2c8fbab4e8d5ae751ccaaacbc91390268c) [ci:PR] remove the faulty tag - [`e71ec25`](https://github.com/games-on-whales/fenrir/commit/e71ec256cd4d3a2c26a694f25cc691fa36eef0cb) [ci] add makefile and timeout to go test - [`5072452`](https://github.com/games-on-whales/fenrir/commit/50724526262a1334700c60f3b3d82a4db4e79f09) [tests] comment out config tests - [`170bfc3`](https://github.com/games-on-whales/fenrir/commit/170bfc338a51f1000dd177f72f831e290538765d) [ci] uncomment the release logic - [`cf75e53`](https://github.com/games-on-whales/fenrir/commit/cf75e53bedb1c7bd71b783c7c38fcf6992538a4e) [lint] use the correct import name for fenrir - [`bdc3397`](https://github.com/games-on-whales/fenrir/commit/bdc33976c987a6fcf8b7d91715bde6475add23bf) [crds] remove faulty quotation ### 📊 Changes **10 files changed** (+440 additions, -102 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/build.yml` (+37 -0) 📝 `.github/workflows/builder.yml` (+1 -1) ➕ `.github/workflows/golangci-lint.yml` (+20 -0) ➕ `.github/workflows/test.yml` (+36 -0) ➕ `.golangci.yml` (+221 -0) ➕ `Makefile` (+25 -0) 📝 `pkg/api/v1alpha1/app.go` (+2 -3) 📝 `pkg/controllers/config_test.go` (+36 -36) 📝 `pkg/controllers/session_test.go` (+4 -4) 📝 `pkg/wolfapi/client_test.go` (+58 -58) </details> ### 📄 Description This PR aims to add `golangci-lint` alongside some tests during the PR process. I've tried to follow the example set in [kubernetes-sigs/cluster-api: golangci.yml](https://github.com/kubernetes-sigs/cluster-api/blob/main/.golangci.yml) alongside a few other sigs projects. I've commented out the pull_request from `.github/workflows/builder.yml` and added a new workflow `.github/workflows/build.yml` that just builds the images for the PR without pushing them, so that images are only built then pushed on merging to main. I'm considering rewriting `.github/workflows/builder.yml` to just follow DRY and remove `build.yml` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:46:39 +00:00