mirror of
https://github.com/games-on-whales/gow.git
synced 2026-10-15 21:02:02 +00:00
[PR #210] added WAYBAR_HIDDEN env var used to hide the waybar #229
Labels
No labels
bug
enhancement
enhancement
github_actions
good first issue
help wanted
help wanted
invalid
needs testers
pull-request
question
x11-images
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
games-on-whales/gow#229
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/games-on-whales/gow/pull/210
Author: @Skerga
Created: 2/8/2025
Status: 🔄 Open
Base:
master← Head:hide-toolbar📝 Commits (3)
204f678added WAYBAR_HIDDEN env var used to hide the waybarfa10518added WAYBAR_HIDDEN=true to the accepted syntax6ac3103changed the way the hiding works📊 Changes
4 files changed (+42 additions, -0 deletions)
View changed files
📝
images/base-app/Dockerfile(+1 -0)📝
images/base-app/configs/waybar/config.jsonc(+3 -0)📝
images/base-app/scripts/launch-comp.sh(+2 -0)➕
images/base-app/scripts/reconfig-waqybar.py(+36 -0)📄 Description
Added a check for
WAYBAR_HIDDEN=yesto the base-app image.side effect is that this made it necessary to overwrite
$HOME/.config/waybar/config.jsoncon every start to allow to switch between hidden and visible. Also every image using the base-app image will need to be rebuild.i tested the change with a local build Lutris image and it worked fine.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.