[PR #210] added WAYBAR_HIDDEN env var used to hide the waybar #229

Open
opened 2026-10-15 12:50:09 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gow/pull/210
Author: @Skerga
Created: 2/8/2025
Status: 🔄 Open

Base: master ← Head: hide-toolbar


📝 Commits (3)

  • 204f678 added WAYBAR_HIDDEN env var used to hide the waybar
  • fa10518 added WAYBAR_HIDDEN=true to the accepted syntax
  • 6ac3103 changed the way the hiding works

📊 Changes

4 files changed (+42 additions, -0 deletions)

View changed files

📝 images/base-app/Dockerfile (+1 -0)
📝 images/base-app/configs/waybar/config.jsonc (+3 -0)
📝 images/base-app/scripts/launch-comp.sh (+2 -0)
➕ images/base-app/scripts/reconfig-waqybar.py (+36 -0)

📄 Description

Added a check for WAYBAR_HIDDEN=yes to the base-app image.

side effect is that this made it necessary to overwrite $HOME/.config/waybar/config.jsonc on every start to allow to switch between hidden and visible. Also every image using the base-app image will need to be rebuild.

i tested the change with a local build Lutris image and it worked fine.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gow/pull/210 **Author:** [@Skerga](https://github.com/Skerga) **Created:** 2/8/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `hide-toolbar` --- ### 📝 Commits (3) - [`204f678`](https://github.com/games-on-whales/gow/commit/204f678c0141a5b775a14802cc15974f8418efd2) added WAYBAR_HIDDEN env var used to hide the waybar - [`fa10518`](https://github.com/games-on-whales/gow/commit/fa10518955e0c9e593e8e178e38b92af315f35c3) added WAYBAR_HIDDEN=true to the accepted syntax - [`6ac3103`](https://github.com/games-on-whales/gow/commit/6ac310318185861492a7d3b945b1c568a438fcb5) changed the way the hiding works ### 📊 Changes **4 files changed** (+42 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `images/base-app/Dockerfile` (+1 -0) 📝 `images/base-app/configs/waybar/config.jsonc` (+3 -0) 📝 `images/base-app/scripts/launch-comp.sh` (+2 -0) ➕ `images/base-app/scripts/reconfig-waqybar.py` (+36 -0) </details> ### 📄 Description Added a check for `WAYBAR_HIDDEN=yes` to the base-app image. side effect is that this made it necessary to overwrite `$HOME/.config/waybar/config.jsonc` on every start to allow to switch between hidden and visible. Also every image using the base-app image will need to be rebuild. i tested the change with a local build Lutris image and it worked fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/gow#229
No description provided.