[PR #42] [MERGED] [1/5] Fix flaky pen-tablet test assertions #44

New issue

Closed

opened 2026-10-15 12:51:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/inputtino/pull/42
Author: @kmreisi
Created: 6/28/2026
Status: ✅ Merged
Merged: 7/13/2026
Merged by: @ABeltramo

Base: stable ← Head: fix/pen-tablet-flaky-test

📝 Commits (1)

70e7d94 Fix flaky pen tablet distance/pressure test assertions

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 tests/testLibinput.cpp (+5 -4)

📄 Description

[1/5] in the dynamic-UHID-joypads roadmap (see #44).

A tiny, standalone test-stabilization: the pen-tablet libinput test compared
floating-point distance/pressure with ==, which is flaky. Switch to Catch2's
WithinAbs matcher.

Independent of the rest of the stack — safe to merge any time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/inputtino/pull/42 **Author:** [@kmreisi](https://github.com/kmreisi) **Created:** 6/28/2026 **Status:** ✅ Merged **Merged:** 7/13/2026 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `stable` ← **Head:** `fix/pen-tablet-flaky-test` --- ### 📝 Commits (1) - [`70e7d94`](https://github.com/games-on-whales/inputtino/commit/70e7d941f6bf6baf4f1264cee305bd5b058ac1ba) Fix flaky pen tablet distance/pressure test assertions ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/testLibinput.cpp` (+5 -4) </details> ### 📄 Description **`[1/5]` in the dynamic-UHID-joypads roadmap (see #44).** A tiny, standalone test-stabilization: the pen-tablet libinput test compared floating-point distance/pressure with `==`, which is flaky. Switch to Catch2's `WithinAbs` matcher. Independent of the rest of the stack — safe to merge any time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-15 12:51:34 +00:00

bsakaguchi referenced this issue

2026-10-15 12:51:34 +00:00

[PR #41] [5/5] Joy-Con (L/R) support #45

bsakaguchi closed this issue

2026-10-15 12:51:34 +00:00

bsakaguchi referenced this issue

2026-10-15 12:51:36 +00:00

[PR #43] [2/5] MAC handling: Mac struct + pooled allocation (PS5) #46