[PR #22] [MERGED] Container names + Compose Manager plg-level check (2026.04.25 followups) #44

New issue

Closed

opened 2026-10-15 12:55:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:55:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/unraid-plugin/pull/22
Author: @JBailes
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @JBailes

Base: wolf-plugin-rewrite ← Head: followups-2026.04.25

📝 Commits (3)

feeb9b8 Pin container_name to wolf and wolf-den in generated compose
6187eb5 Merge pull request #21 from games-on-whales/fix-container-names
32a838b Move Compose Manager check from preinstall.sh to plg FILE Run

📊 Changes

3 files changed (+22 additions, -9 deletions)

View changed files

📝 gow.plg (+18 -1)
📝 scripts/deploy.sh (+4 -0)
📝 scripts/preinstall.sh (+0 -8)

📄 Description

Three commits that belong on `wolf-plugin-rewrite` but got parked on the `require-docker-compose` branch when #21 landed into the wrong base. Stacks on #18.

Summary

feeb9b8 — Pin `container_name: wolf` and `container_name: wolf-den` in both compose templates. Without this, Compose v2 auto-names containers `gow-wolf-1` / `gow-wolf-den-1` and the settings UI's `docker inspect wolf` / `docker inspect wolf-den` probes miss, so the dashboard shows "Not deployed" even when the stack is running. (Was originally #21, merged into the PR #20 branch instead of `wolf-plugin-rewrite`.)
32a838b — Replace the runtime `docker compose version` probe in `preinstall.sh` with a plg-level `` check for `/boot/config/plugins/compose.manager.plg`, matching the pattern Unassigned Devices Plus uses to require Unassigned Devices. Fails earlier (before any scripts are downloaded) and is explicit about the required Community Applications plugin.

Test plan

Install plg without Compose Manager → abort message referencing Compose Manager, no scripts downloaded.
Install plg with Compose Manager → install proceeds, preinstall.sh passes, deploy completes.
Fresh deploy → containers named `wolf` and `wolf-den`, settings UI shows Running.
Reconfigure from an install still using `gow-wolf-1` names → compose down removes the old ones, new `wolf`/`wolf-den` come up, dashboard updates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/unraid-plugin/pull/22 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `wolf-plugin-rewrite` ← **Head:** `followups-2026.04.25` --- ### 📝 Commits (3) - [`feeb9b8`](https://github.com/games-on-whales/unraid-plugin/commit/feeb9b8e5cccf5b3fad2aca6d4032725d2194e0b) Pin container_name to wolf and wolf-den in generated compose - [`6187eb5`](https://github.com/games-on-whales/unraid-plugin/commit/6187eb546c3fa2fa62bd2b4e07c8c3278780ea7e) Merge pull request #21 from games-on-whales/fix-container-names - [`32a838b`](https://github.com/games-on-whales/unraid-plugin/commit/32a838b7e3fe0a45dfd688a9ebe40a1cd385403f) Move Compose Manager check from preinstall.sh to plg FILE Run ### 📊 Changes **3 files changed** (+22 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `gow.plg` (+18 -1) 📝 `scripts/deploy.sh` (+4 -0) 📝 `scripts/preinstall.sh` (+0 -8) </details> ### 📄 Description Three commits that belong on \`wolf-plugin-rewrite\` but got parked on the \`require-docker-compose\` branch when #21 landed into the wrong base. Stacks on #18. ## Summary - **feeb9b8** — Pin \`container_name: wolf\` and \`container_name: wolf-den\` in both compose templates. Without this, Compose v2 auto-names containers \`gow-wolf-1\` / \`gow-wolf-den-1\` and the settings UI's \`docker inspect wolf\` / \`docker inspect wolf-den\` probes miss, so the dashboard shows "Not deployed" even when the stack is running. (Was originally #21, merged into the PR #20 branch instead of \`wolf-plugin-rewrite\`.) - **32a838b** — Replace the runtime \`docker compose version\` probe in \`preinstall.sh\` with a plg-level \`<FILE Run>\` check for \`/boot/config/plugins/compose.manager.plg\`, matching the pattern Unassigned Devices Plus uses to require Unassigned Devices. Fails earlier (before any scripts are downloaded) and is explicit about the required Community Applications plugin. ## Test plan - [ ] Install plg without Compose Manager → abort message referencing Compose Manager, no scripts downloaded. - [ ] Install plg with Compose Manager → install proceeds, preinstall.sh passes, deploy completes. - [ ] Fresh deploy → containers named \`wolf\` and \`wolf-den\`, settings UI shows Running. - [ ] Reconfigure from an install still using \`gow-wolf-1\` names → compose down removes the old ones, new \`wolf\`/\`wolf-den\` come up, dashboard updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:55:07 +00:00