[PR #21] [MERGED] Pin container_name to wolf and wolf-den in generated compose #45

New issue

Closed

opened 2026-10-15 12:55:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:55:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/unraid-plugin/pull/21
Author: @JBailes
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @JBailes

Base: require-docker-compose ← Head: fix-container-names

📝 Commits (1)

feeb9b8 Pin container_name to wolf and wolf-den in generated compose

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 gow.plg (+1 -0)
📝 scripts/deploy.sh (+4 -0)

📄 Description

Stacks on top of #20 (which stacks on #18). Fixes the "Not deployed" status badges the tester reported.

Summary

Without `container_name`, Docker Compose v2 names containers `--1`, i.e. `gow-wolf-1` and `gow-wolf-den-1` under the default `APPDATA=/mnt/user/appdata/gow`. But `gow.page` calls `docker inspect wolf` / `docker inspect wolf-den`, so every deployed install showed "Not deployed" badges even with both containers running.

Added `container_name: wolf` and `container_name: wolf-den` to both services in both compose templates (NVIDIA + standard in `deploy.sh`). No PHP changes needed — the inspect calls now resolve.

Changelog entry for 2026.04.25 extended to mention this fix; no extra version bump (both #20 and this PR land as 2026.04.25).

Migration

Fresh installs: work out of the box.
Existing installs: `deploy.sh` already runs `docker compose down` before rewriting the compose file, so clicking Reconfigure once is enough to tear down the old mangled containers and bring up the newly-named ones. Plain `update.sh` does not regenerate the compose file, so "Update Images" alone won't migrate — flagged in the PR body so maintainers can mention it in release notes if needed.

Test plan

Fresh install on a clean Unraid box → settings UI shows Running for both Wolf and Wolf Den.
Upgrade from a pre-2026.04.25 install, click Reconfigure → old `gow-wolf-1`/`gow-wolf-den-1` containers removed, new `wolf`/`wolf-den` containers running, status badges switch to Running.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/unraid-plugin/pull/21 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `require-docker-compose` ← **Head:** `fix-container-names` --- ### 📝 Commits (1) - [`feeb9b8`](https://github.com/games-on-whales/unraid-plugin/commit/feeb9b8e5cccf5b3fad2aca6d4032725d2194e0b) Pin container_name to wolf and wolf-den in generated compose ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `gow.plg` (+1 -0) 📝 `scripts/deploy.sh` (+4 -0) </details> ### 📄 Description Stacks on top of #20 (which stacks on #18). Fixes the "Not deployed" status badges the tester reported. ## Summary Without \`container_name\`, Docker Compose v2 names containers \`<project>-<service>-1\`, i.e. \`gow-wolf-1\` and \`gow-wolf-den-1\` under the default \`APPDATA=/mnt/user/appdata/gow\`. But \`gow.page\` calls \`docker inspect wolf\` / \`docker inspect wolf-den\`, so every deployed install showed "Not deployed" badges even with both containers running. Added \`container_name: wolf\` and \`container_name: wolf-den\` to both services in both compose templates (NVIDIA + standard in \`deploy.sh\`). No PHP changes needed — the inspect calls now resolve. Changelog entry for 2026.04.25 extended to mention this fix; no extra version bump (both #20 and this PR land as 2026.04.25). ## Migration - **Fresh installs:** work out of the box. - **Existing installs:** \`deploy.sh\` already runs \`docker compose down\` before rewriting the compose file, so clicking **Reconfigure** once is enough to tear down the old mangled containers and bring up the newly-named ones. Plain \`update.sh\` does not regenerate the compose file, so "Update Images" alone won't migrate — flagged in the PR body so maintainers can mention it in release notes if needed. ## Test plan - [ ] Fresh install on a clean Unraid box → settings UI shows Running for both Wolf and Wolf Den. - [ ] Upgrade from a pre-2026.04.25 install, click Reconfigure → old \`gow-wolf-1\`/\`gow-wolf-den-1\` containers removed, new \`wolf\`/\`wolf-den\` containers running, status badges switch to Running. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:55:07 +00:00