mirror of
https://github.com/games-on-whales/wolf.git
synced 2026-10-15 21:12:08 +00:00
[GH-ISSUE #151] Memory leak on AMD when using HEVC only #102
Labels
No labels
🧠 1 - 🤖 999
AMD
bug
bug
cannot reproduce
documentation
duplicate
easy
enhancement
enhancement
enhancement
fixed?
fixed?
good first issue
hard
help wanted
Intel
invalid
LXC
medium
moonlight-protocol
Multi GPU
nixos
not a bug
nvidia
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
games-on-whales/wolf#102
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Skerga on GitHub (Nov 23, 2024).
Original GitHub issue: https://github.com/games-on-whales/wolf/issues/151
Hey I observed a Memory leak when connecting to wolf via an Android client.
on my laptop no Memory leak occurs, so i think its Android exclusive.
Memory leak occurs the second the stream starts (no actions need to be performed on the client on the running container).
Here my compose file:
here are debug logs from a short firefox session:
wolf_log_firefox.log
and a debug log from Lutrs untill all ram was exhaused:
wolf_log_lutris..log
and here the crash dump created after running out of memory:
dump.zip
@ABeltramo commented on GitHub (Nov 23, 2024):
Before I dive into this, a quick question: are you running latest Wolf image?
You can update using
And restart the container
@Skerga commented on GitHub (Nov 24, 2024):
I pulled all images just before i tested, after i realised there is a problem happening.
Just tried again and it didn't happen. But i had this kind of problem before once already, my guess is that this happens only under some conditions. but i'm not yet sure what might trigger it to happen.
I'll keep an eye on this maybe i find what action causes this to happen.
@Skerga commented on GitHub (Nov 24, 2024):
I managed to trigger it again, while playing. Using the newest image the problem started after this msg apeard in the log:
afterwards every used image gets the leak, persistant even after restarting the wolf container. only a Host restart seemed to fix it.
A symptom of this problem is an extremly sluggish mouse, delayed by more that a second.
@ABeltramo commented on GitHub (Nov 25, 2024):
I've tested a few things in code and I can't reproduce a memory leak when hitting that edge case so I don't think that's the underlying cause of it; I'm way more suspicious by the fact that this is only triggered by Moonlight Android and I'd like to dig deeper there: what are the differences between the laptop and the Android client?
CTRL+ALT+SHIFT+Son your laptop and by setting the stats overlay in the Moonlight Android settings before connecting?I think that what's happening here is that for some reason the host can't keep up the requested framerate (could be GPU, network or other) and when that happens we are leaking some frames in our encoding pipeline.
@Skerga commented on GitHub (Nov 26, 2024):
I think i found what causes this for me:
Android decoder settings are set to Auto on default, that lead to android using: "c2.exynos.hvec.decoder"(h.265) after forcing h.264 like my laptop uses, which is also set to auto, the problem disappeared.
Just for completions sake:
In conclusion: the h.265 implementation of my GPU is shit... which will most likely lead to frames not being processed causing some buffer to grow until all memory is used up.
@kode54 commented on GitHub (Jan 9, 2025):
I appear to have triggered this with an AMD RX 7700 XT as the host GPU running on Docker on an Arch machine, serving to an M4 Pro Mac mini. It doesn't trigger under most games, but it triggered this time when running Borderlands 3.
Borderlands 3 also wanted to start running while the shader compilation was going, which I had to cancel, but could not, because the leak caused it to spiral out of control.
@kode54 commented on GitHub (Jan 9, 2025):
Nope, Borderlands 3 makes it continuously leak memory even with H.264.
@ABeltramo commented on GitHub (Jan 9, 2025):
I need a bit more info:
CTRL+ALT+SHIFT+Son desktop) and report what you see there?@ABeltramo commented on GitHub (Jan 9, 2025):
Btw there are tons of reports on protondb https://www.protondb.com/app/397540 with all kind of issues, might be something specific to this game and Proton..
@kode54 commented on GitHub (Jan 10, 2025):
wolf process "res" stat climbing past 45g.
Reliably shortly after starting the game, by the time it reaches the menu.
I'll check and report back when I'm on my desktop again.
Figures it would break in the time since I last checked it, in November.
@ABeltramo commented on GitHub (Jan 10, 2025):
I've just pushed a fix that should potentially fix this, you can update to the latest with:
Let me know how it goes!
@kode54 commented on GitHub (Jan 10, 2025):
That fixed it, thanks!
@ABeltramo commented on GitHub (Jan 10, 2025):
Thanks for testing it out!