[PR #11] [MERGED] Security: Fix critical user data isolation vulnerabilities in paired … #37

Closed
opened 2026-10-15 13:01:50 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolfmanager/pull/11
Author: @salty2011
Created: 6/1/2025
Status: ✅ Merged
Merged: 6/1/2025
Merged by: @salty2011

Base: stable ← Head: fix/paired-clients-user-isolation


📝 Commits (1)

  • 20efae7 Security: Fix critical user data isolation vulnerabilities in paired clients

📊 Changes

3 files changed (+215 additions, -27 deletions)

View changed files

📝 src/app/clients/actions.ts (+186 -12)
📝 src/app/clients/components/ClientPageContent.tsx (+14 -7)
📝 src/app/clients/page.tsx (+15 -8)

📄 Description

…clients

  • Fixed Issue 4: Paired clients displaying for all users instead of user-specific data
  • Implemented proper user session validation and client filtering
  • Added ownership validation for all client operations (view, unpair, delete)
  • Enhanced security by ensuring users can only see and manage their own paired clients

Changes:

  • src/app/clients/actions.ts: Added user session validation and user-specific filtering
  • src/app/clients/page.tsx: Implemented proper user context passing to components
  • src/app/clients/components/ClientPageContent.tsx: Added client-side user validation

Impact: Users now have complete data isolation - can only view/manage their own paired clients


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolfmanager/pull/11 **Author:** [@salty2011](https://github.com/salty2011) **Created:** 6/1/2025 **Status:** ✅ Merged **Merged:** 6/1/2025 **Merged by:** [@salty2011](https://github.com/salty2011) **Base:** `stable` ← **Head:** `fix/paired-clients-user-isolation` --- ### 📝 Commits (1) - [`20efae7`](https://github.com/games-on-whales/wolfmanager/commit/20efae7458091b0f307b4d10ec7164235c055a49) Security: Fix critical user data isolation vulnerabilities in paired clients ### 📊 Changes **3 files changed** (+215 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/app/clients/actions.ts` (+186 -12) 📝 `src/app/clients/components/ClientPageContent.tsx` (+14 -7) 📝 `src/app/clients/page.tsx` (+15 -8) </details> ### 📄 Description …clients - Fixed Issue 4: Paired clients displaying for all users instead of user-specific data - Implemented proper user session validation and client filtering - Added ownership validation for all client operations (view, unpair, delete) - Enhanced security by ensuring users can only see and manage their own paired clients Changes: - src/app/clients/actions.ts: Added user session validation and user-specific filtering - src/app/clients/page.tsx: Implemented proper user context passing to components - src/app/clients/components/ClientPageContent.tsx: Added client-side user validation Impact: Users now have complete data isolation - can only view/manage their own paired clients --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 13:01:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/wolfmanager#37
No description provided.