ikawrakow/ik_llama.cpp
1
0
Fork 0
mirror of https://github.com/ikawrakow/ik_llama.cpp.git synced 2026-01-26 09:09:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
main
ik_llama.cpp/github-data/pull_requests/369 - cmake_ force MSVC compiler charset to utf-8.md
Thomas eaa2510a28 Add GitHub data: filename sanitization (#640)
2025-07-23 13:31:53 +02:00

1.4 KiB
Raw Permalink Blame History

🔀 #369 - cmake: force MSVC compiler charset to utf-8

Author Gaolingx
State ❌ Closed
Created 2025-05-03
Updated 2025-05-03

Description

This commit is to prevent tests\test-grammar-integration.cpp(483,13): error C2001: newline in constant showing up in non-UTF8 windows system while using MSVC.

image

💬 Conversation

👤 ikawrakow submitted a review the 2025-05-03 at 12:26:22: ✅ APPROVED

LGTM, but I cannot test. It would be useful if at least one other person tested before we merge.

👤 ikawrakow submitted a review the 2025-05-03 at 12:26:22: ✅ APPROVED

LGTM, but I cannot test.

👤 Gaolingx commented the 2025-05-03 at 12:54:45:

LGTM, but I cannot test. It would be useful if at least one other person tested before we merge.

At first, it couldn't be compiled while using MSVC, then I found the solution https://github.com/ggml-org/llama.cpp/pull/9989 , Well, it worked.