[PR #295] [MERGED] Resolve tools version from launch configuration #323

Closed
opened 2026-10-29 14:22:13 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/295
Author: @guozy18
Created: 9/16/2026
Status: ✅ Merged
Merged: 9/16/2026
Merged by: @yingdi-shan

Base: main ← Head: main


📝 Commits (1)

  • 7763e07 fix(sandbox): resolve tools version from launch config

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/sandbox/firecracker/sandbox.rs (+2 -1)

📄 Description

What

Why

Closes #

Scope and non-goals

Design and behavior changes

Compatibility and operations

  • Public API or generated protocol:
  • Configuration or defaults:
  • Snapshot manifest, artifact layout, or storage format:
  • Upgrade and rollback:
  • Host requirements, permissions, ports, or dependencies:

Validation

  • make fmt
  • make clippy
  • make test-unit
  • Relevant Rust integration tests
  • make -C services test (required when services/ changes)
  • Generated clients/server regenerated with the documented make target
  • Documentation updated
  • Benchmarks or performance comparison completed

Commands and results:


Skipped checks and reasons:

Risks and reviewer notes

Checklist

  • The PR contains one coherent change and no unrelated formatting or refactoring.
  • New behavior is covered by tests, or I explained why testing is impractical.
  • Logs and examples contain no credentials, tokens, or private registry information.
  • I did not manually edit generated code without updating its source and regenerating it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/295 **Author:** [@guozy18](https://github.com/guozy18) **Created:** 9/16/2026 **Status:** ✅ Merged **Merged:** 9/16/2026 **Merged by:** [@yingdi-shan](https://github.com/yingdi-shan) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`7763e07`](https://github.com/kvcache-ai/AgentENV/commit/7763e079a50fcb65be0f263ac7cec4e143fc1cd9) fix(sandbox): resolve tools version from launch config ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/sandbox/firecracker/sandbox.rs` (+2 -1) </details> ### 📄 Description ## What <!-- Summarize the change. Keep the PR focused on one problem. --> ## Why <!-- Explain the user or maintainer problem this solves. --> ## Related issue <!-- Use "Closes #123" for an issue resolved by this PR. Non-trivial changes should normally have an issue or prior design discussion. --> Closes # ## Scope and non-goals <!-- State what is intentionally included and excluded. Call out unrelated refactors. --> ## Design and behavior changes <!-- Describe important data flow, lifecycle, failure handling, concurrency, or operational changes. Include diagrams for substantial changes. --> ## Compatibility and operations <!-- Explain applicable compatibility and deployment impact. Write "N/A" with a reason where appropriate. --> - Public API or generated protocol: - Configuration or defaults: - Snapshot manifest, artifact layout, or storage format: - Upgrade and rollback: - Host requirements, permissions, ports, or dependencies: ## Validation <!-- Check only commands you actually ran. Add focused tests and exact commands below. --> - [ ] `make fmt` - [ ] `make clippy` - [ ] `make test-unit` - [ ] Relevant Rust integration tests - [ ] `make -C services test` (required when `services/` changes) - [ ] Generated clients/server regenerated with the documented `make` target - [ ] Documentation updated - [ ] Benchmarks or performance comparison completed Commands and results: ```text ``` Skipped checks and reasons: ## Risks and reviewer notes <!-- Identify correctness, security, compatibility, resource, and operational risks. Point reviewers to the most important files or commits. --> ## Checklist - [ ] The PR contains one coherent change and no unrelated formatting or refactoring. - [ ] New behavior is covered by tests, or I explained why testing is impractical. - [ ] Logs and examples contain no credentials, tokens, or private registry information. - [ ] I did not manually edit generated code without updating its source and regenerating it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-29 14:22:13 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kvcache-ai/AgentENV#323
No description provided.