[PR #323] [MERGED] fix(test): switch MinIO test image to pgsty/silo #347

New issue

Closed

opened 2026-10-29 14:22:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:22:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/323
Author: @huajq
Created: 9/28/2026
Status: ✅ Merged
Merged: 9/28/2026
Merged by: @yingdi-shan

Base: main ← Head: fix/minio-silo-test-image

📝 Commits (1)

d0a4135 fix(test): switch MinIO test image to pgsty/silo

📊 Changes

1 file changed (+8 additions, -6 deletions)

View changed files

📝 crates/test-support/src/minio.rs (+8 -6)

📄 Description

What

Point the shared MinIO test fixture (MinioFixture::start() in
crates/test-support/src/minio.rs) at pgsty/silo:RELEASE.2026-09-16T00-00-00Z
instead of quay.io/minio/minio.

Why

MinIO's community distribution has ended: the GitHub repo is archived and
marked "no longer maintained", Docker Hub deleted minio/minio
(2026-09-11), and quay.io/minio/minio — the source #285 switched to — has
been made private (anonymous pulls now return 401). Every MinIO-backed OSS
test fails to pull its container again.

Silo is the actively maintained community fork. It preserves MinIO's wire
behavior, MINIO_* environment variables, legacy server /data argv, and
the stderr startup banner, so only the image name and pinned tag change; the
readiness probe, credentials, and command stay as they are.

No linked issue. Follow-up to #285.

Scope and non-goals

Includes only the test fixture image change. No production code changes.

Design and behavior changes

Image: pgsty/silo:RELEASE.2026-09-16T00-00-00Z (pinned, multi-arch
amd64/arm64 manifest list) instead of latest for deterministic tests.
Verified locally that the banner's API: line still goes to stderr and
that auth is still enforced (correct credentials 200, wrong credentials
403), so WaitFor::message_on_stderr("API:") and the
wrong-credentials tests keep working unchanged.

Compatibility and operations

Public API or generated protocol: N/A (test-only change).
Configuration or defaults: N/A.
Snapshot manifest, artifact layout, or storage format: N/A.
Upgrade and rollback: N/A.
Host requirements, permissions, ports, or dependencies: test runs now pull
the container from Docker Hub (pgsty/silo) instead of quay.io; hosts
running these suites need outbound access to Docker Hub. MinIO's
nearly-full-disk XMinioStorageFull behavior is unchanged.

Validation

make fmt
make clippy
make test-unit
Relevant Rust integration tests
make -C services test (required when services/ changes)
Generated clients/server regenerated with the documented make target
Documentation updated
Benchmarks or performance comparison completed

Commands and results (Linux host with Docker):

make fmt
  PASS
cargo clippy -p agentenv-test-support --all-targets -- -D warnings
  PASS
cargo test -p overlaybd --test oss_backend_minio -- --ignored
  7 passed; 0 failed
cargo test -p agentenv-e2e-tests --test snapshot_oss_e2e_test -- --ignored
  5 passed; 0 failed

Skipped checks and reasons:

Workspace-wide make clippy and make test-unit were not run; the change
is confined to one test-support file and passed targeted clippy and the
workspace format check. No services/ or generated-code changes, and no doc
update was needed.

Risks and reviewer notes

Test-only; no runtime risk. Silo is a community fork maintained by Pigsty
rather than MinIO, Inc.; if its Docker Hub repository ever becomes
unavailable, the same failure mode returns — mirroring the image into a
project-controlled registry (e.g. ghcr.io/kvcache-ai) would be a follow-up
ops decision rather than part of this fix.

Checklist

The PR contains one coherent change and no unrelated formatting or refactoring.
New behavior is covered by tests, or I explained why testing is impractical.
Logs and examples contain no credentials, tokens, or private registry
information. (minioadmin/minioadmin are MinIO's public well-known local
test defaults.)
I did not manually edit generated code without updating its source and regenerating it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/323 **Author:** [@huajq](https://github.com/huajq) **Created:** 9/28/2026 **Status:** ✅ Merged **Merged:** 9/28/2026 **Merged by:** [@yingdi-shan](https://github.com/yingdi-shan) **Base:** `main` ← **Head:** `fix/minio-silo-test-image` --- ### 📝 Commits (1) - [`d0a4135`](https://github.com/kvcache-ai/AgentENV/commit/d0a4135adc757ce5b7cb5c2a50fdf1cfcad10724) fix(test): switch MinIO test image to pgsty/silo ### 📊 Changes **1 file changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `crates/test-support/src/minio.rs` (+8 -6) </details> ### 📄 Description ## What Point the shared MinIO test fixture (`MinioFixture::start()` in `crates/test-support/src/minio.rs`) at `pgsty/silo:RELEASE.2026-09-16T00-00-00Z` instead of `quay.io/minio/minio`. ## Why MinIO's community distribution has ended: the GitHub repo is archived and marked "no longer maintained", Docker Hub deleted `minio/minio` (2026-09-11), and `quay.io/minio/minio` — the source #285 switched to — has been made private (anonymous pulls now return 401). Every MinIO-backed OSS test fails to pull its container again. Silo is the actively maintained community fork. It preserves MinIO's wire behavior, `MINIO_*` environment variables, legacy `server /data` argv, and the stderr startup banner, so only the image name and pinned tag change; the readiness probe, credentials, and command stay as they are. ## Related issue No linked issue. Follow-up to #285. ## Scope and non-goals Includes only the test fixture image change. No production code changes. ## Design and behavior changes - Image: `pgsty/silo:RELEASE.2026-09-16T00-00-00Z` (pinned, multi-arch amd64/arm64 manifest list) instead of `latest` for deterministic tests. - Verified locally that the banner's `API:` line still goes to stderr and that auth is still enforced (correct credentials 200, wrong credentials 403), so `WaitFor::message_on_stderr("API:")` and the wrong-credentials tests keep working unchanged. ## Compatibility and operations - Public API or generated protocol: N/A (test-only change). - Configuration or defaults: N/A. - Snapshot manifest, artifact layout, or storage format: N/A. - Upgrade and rollback: N/A. - Host requirements, permissions, ports, or dependencies: test runs now pull the container from Docker Hub (`pgsty/silo`) instead of quay.io; hosts running these suites need outbound access to Docker Hub. MinIO's nearly-full-disk `XMinioStorageFull` behavior is unchanged. ## Validation - [x] `make fmt` - [ ] `make clippy` - [ ] `make test-unit` - [x] Relevant Rust integration tests - [ ] `make -C services test` (required when `services/` changes) - [ ] Generated clients/server regenerated with the documented `make` target - [ ] Documentation updated - [ ] Benchmarks or performance comparison completed Commands and results (Linux host with Docker): ```text make fmt PASS cargo clippy -p agentenv-test-support --all-targets -- -D warnings PASS cargo test -p overlaybd --test oss_backend_minio -- --ignored 7 passed; 0 failed cargo test -p agentenv-e2e-tests --test snapshot_oss_e2e_test -- --ignored 5 passed; 0 failed ``` Skipped checks and reasons: Workspace-wide `make clippy` and `make test-unit` were not run; the change is confined to one test-support file and passed targeted clippy and the workspace format check. No `services/` or generated-code changes, and no doc update was needed. ## Risks and reviewer notes Test-only; no runtime risk. Silo is a community fork maintained by Pigsty rather than MinIO, Inc.; if its Docker Hub repository ever becomes unavailable, the same failure mode returns — mirroring the image into a project-controlled registry (e.g. ghcr.io/kvcache-ai) would be a follow-up ops decision rather than part of this fix. ## Checklist - [x] The PR contains one coherent change and no unrelated formatting or refactoring. - [x] New behavior is covered by tests, or I explained why testing is impractical. - [x] Logs and examples contain no credentials, tokens, or private registry information. (minioadmin/minioadmin are MinIO's public well-known local test defaults.) - [x] I did not manually edit generated code without updating its source and regenerating it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:22:28 +00:00