mirror of
https://github.com/kvcache-ai/AgentENV.git
synced 2026-11-05 01:17:36 +00:00
[PR #354] [MERGED] ci: request medium reasoning effort in OpenCodeReview #373
Labels
No labels
bug
documentation
enhancement
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
kvcache-ai/AgentENV#373
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/kvcache-ai/AgentENV/pull/354
Author: @yingdi-shan
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @yingdi-shan
Base:
main← Head:ci/ocr-reasoning-effort📝 Commits (1)
5693cdeci: request medium reasoning effort in OpenCodeReview📊 Changes
1 file changed (+6 additions, -0 deletions)
View changed files
📝
.github/workflows/open-code-review.yml(+6 -0)📄 Description
What
On the
alibaba/open-code-reviewstep, setllm_extra_body: '{}'so that the action stops sending its default{"thinking": {"type": "disabled"}}body, and setllm_reasoning_effort: medium.Why
The OpenCodeReview job fails with:
The OpenAI-compatible endpoint maps the action's default "thinking disabled"
extra_bodytoreasoning_effort: "none", and the configured model rejects that value. With an emptyextra_bodyandllm_reasoning_effort: medium, the request carriesreasoning_effort: "medium", a value the model accepts. Theeffortinput does not help here: it only sets the number of review rounds.Related issue
N/A
Scope and non-goals
Only the workflow inputs change. The review-round
effortinput is left at its default.Design and behavior changes
LLM review requests no longer disable thinking and instead ask for medium reasoning effort. Reviews may use more tokens and take somewhat longer.
Compatibility and operations
reasoning_effort: "medium"instead ofthinking: disabled.llm_reasoning_effortapplies to OpenAI-compatible protocols only; the action fails fast ifOCR_LLM_USE_ANTHROPICis enabled while it is set, so switching to Anthropic also requires removing it.Validation
make fmtmake clippymake test-unitmake -C services test(required whenservices/changes)maketargetCommands and results:
Skipped checks and reasons: CI workflow-only change; no Rust or Go code changed. The real validation is the OpenCodeReview run, which only runs from the base repository's
pull_request_targetworkflow after this merges.Risks and reviewer notes
Because the workflow is
pull_request_target, this PR's own OCR run still uses the workflow frommain, so it is expected to fail with the same error until this merges.Checklist
🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.