mirror of
https://github.com/kvcache-ai/Mooncake.git
synced 2026-11-05 01:17:55 +00:00
[GH-ISSUE #4020] [RFC]: Reproducing Table 1 hit rates on the released trace, consistent +4-6pp offset #1020
Labels
No labels
ascend
auto-closed
bug
bug
CI/Build
Common
documentation
enhancement
feature request
good first issue
help wanted
high priority
MetaX
nightly-failure
pull-request
PyTorch Backend
question
RFC
Roadmap
stale
Store
Tests
Transfer Engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
kvcache-ai/Mooncake#1020
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gauravapiscean on GitHub (Sep 10, 2026).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/4020
Originally assigned to: @chestnut-Q on GitHub.
Changes proposed
I've been reproducing your Table 1 cache hit rates on arxiv-trace/mooncake_trace.jsonl using LRU, and I get the same curve shape but a systematic offset at every capacity:
I compute hit rate as (sum of longest-resident-prefix blocks) / (sum of all blocks requested), replaying in timestamp order. Since the infinite-cache case is policy-free, I'd expect it to be reproducible from the trace alone, but I get 0.553 against your 0.51.
I've tried five denominator definitions (blocks vs input_length tokens, excluding the partial tail block, per-request averaging) and none closes the gap. Is the released trace the same one used for Table 1, or is there a detail in the hit-rate definition I'm missing?
Repro: https://github.com/gauravapiscean/agentic-kv-cache
Before submitting a new issue...
@github-actions[bot] commented on GitHub (Sep 10, 2026):
Thanks for opening this issue, @gauravapiscean!
10956383A maintainer will triage this when possible. To help us respond faster, please include:
Useful links: Documentation · Contributing guide
@chestnut-Q commented on GitHub (Oct 8, 2026):
Hi @gauravapiscean, thank you for pointing this. When preparing the trace for release, we filtered out requests marked as
rejected, as their output lengths are 0, which could be confusing. However, the results in Table 1 were computed on the trace before filtering, which explains the gap.I’ll update the paper to correct this inconsistency as soon as possible. Thanks!