[PR #1020] [MERGED] [feat]More KVCache metrics in both master/client side #1958

New issue

Closed

opened 2026-10-29 21:31:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:31:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1020
Author: @Liziqi-77
Created: 11/5/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @stmatengss

Base: main ← Head: main

📝 Commits (8)

698b0c1 More KVCache metrics in both master/client side
f417fbc add UT
1318157 fix bug
1f20623 fix bug
164eab2 fix bug
667ee86 fix bug
77829cc fix log
86bb445 fix bug

📊 Changes

9 files changed (+270 additions, -0 deletions)

View changed files

📝 mooncake-store/include/client.h (+6 -0)
📝 mooncake-store/include/master_client.h (+9 -0)
📝 mooncake-store/include/master_metric_manager.h (+49 -0)
📝 mooncake-store/include/rpc_service.h (+3 -0)
📝 mooncake-store/src/master_client.cpp (+12 -0)
📝 mooncake-store/src/master_metric_manager.cpp (+104 -0)
📝 mooncake-store/src/master_service.cpp (+20 -0)
📝 mooncake-store/src/rpc_service.cpp (+5 -0)
📝 mooncake-store/tests/master_metrics_test.cpp (+62 -0)

📄 Description

background

As mentioned in More KVCache metrics in both master/client side, a new interface for calculating cache hit rate has been added, which calculates the rate separately for memory and SSD.

new feature

Provides an interface for calculating cache statistics: calculate_cache_stats
Calculate the cache hit rate for mem and ssd separately

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1020 **Author:** [@Liziqi-77](https://github.com/Liziqi-77) **Created:** 11/5/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (8) - [`698b0c1`](https://github.com/kvcache-ai/Mooncake/commit/698b0c13f39878a8c81639cd96fd908686f5d417) More KVCache metrics in both master/client side - [`f417fbc`](https://github.com/kvcache-ai/Mooncake/commit/f417fbc114eac096d9da17ec1f398cd930b70224) add UT - [`1318157`](https://github.com/kvcache-ai/Mooncake/commit/13181579d9efbe689ba00660eabdb28b0e5ead49) fix bug - [`1f20623`](https://github.com/kvcache-ai/Mooncake/commit/1f20623c32063202990c756ed59fe10abb2a0722) fix bug - [`164eab2`](https://github.com/kvcache-ai/Mooncake/commit/164eab20be3079f4d459ffd5aa46dd90a32f81ce) fix bug - [`667ee86`](https://github.com/kvcache-ai/Mooncake/commit/667ee868ade741ed8835c3b86365fbe4b0b1ccd8) fix bug - [`77829cc`](https://github.com/kvcache-ai/Mooncake/commit/77829cc863e2ba09d38d27aae789c85133c07777) fix log - [`86bb445`](https://github.com/kvcache-ai/Mooncake/commit/86bb44515aa50dd0d8eb4e40ad0175499d960a59) fix bug ### 📊 Changes **9 files changed** (+270 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/client.h` (+6 -0) 📝 `mooncake-store/include/master_client.h` (+9 -0) 📝 `mooncake-store/include/master_metric_manager.h` (+49 -0) 📝 `mooncake-store/include/rpc_service.h` (+3 -0) 📝 `mooncake-store/src/master_client.cpp` (+12 -0) 📝 `mooncake-store/src/master_metric_manager.cpp` (+104 -0) 📝 `mooncake-store/src/master_service.cpp` (+20 -0) 📝 `mooncake-store/src/rpc_service.cpp` (+5 -0) 📝 `mooncake-store/tests/master_metrics_test.cpp` (+62 -0) </details> ### 📄 Description ## background As mentioned in [More KVCache metrics in both master/client side](https://github.com/kvcache-ai/Mooncake/issues/972), a new interface for calculating cache hit rate has been added, which calculates the rate separately for memory and SSD. ## new feature - Provides an interface for calculating cache statistics: calculate_cache_stats - Calculate the cache hit rate for mem and ssd separately --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:31:41 +00:00