[PR #1129] [MERGED] [Store] Cancel all negative ret val

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2029

bsakaguchi commented

2026-10-29 21:32:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1129
Author: @Azure-Tang
Created: 11/27/2025
Status: ✅ Merged
Merged: 11/27/2025
Merged by: @XucSh

Base: main ← Head: fix-ret

📝 Commits (2)

e5fc251 Cancel all negative ret val. Add to_py_ret func to handle return error code
4375403 format code

📊 Changes

1 file changed (+22 additions, -16 deletions)

View changed files

📝 mooncake-integration/store/store_py.cpp (+22 -16)

📄 Description

Description

The ErrorCode is already a negative value, so there’s no need to negate it again.

Cancel all negtive ret val. Add to_py_ret func to handle return error code

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1129 **Author:** [@Azure-Tang](https://github.com/Azure-Tang) **Created:** 11/27/2025 **Status:** ✅ Merged **Merged:** 11/27/2025 **Merged by:** [@XucSh](https://github.com/XucSh) **Base:** `main` ← **Head:** `fix-ret` --- ### 📝 Commits (2) - [`e5fc251`](https://github.com/kvcache-ai/Mooncake/commit/e5fc251c2ca48c8e921db8bb4a26fefe7537908b) Cancel all negative ret val. Add to_py_ret func to handle return error code - [`4375403`](https://github.com/kvcache-ai/Mooncake/commit/4375403cd952903970bf8427b5180371764c6489) format code ### 📊 Changes **1 file changed** (+22 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-integration/store/store_py.cpp` (+22 -16) </details> ### 📄 Description ## Description The ErrorCode is already a negative value, so there’s no need to negate it again. Cancel all negtive ret val. Add to_py_ret func to handle return error code ## Type of Change * Types - [x] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1129] [MERGED] [Store] Cancel all negative ret val #2029