[PR #1137] [MERGED] [store] Fix IPv6 link-local address parsing and add IPv6 tests

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2036

bsakaguchi commented

2026-10-29 21:32:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1137
Author: @Azure-Tang
Created: 11/28/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @stmatengss

Base: main ← Head: update-ylt

📝 Commits (4)

9db2919 update yanlanting dependency
aa7949c [TE] Fix IPv6 link-local address parsing and add IPv6 tests
d4f3868 [Store] Address PR review feedback for IPv6 support
d41cfa3 format code

📊 Changes

4 files changed (+509 additions, -30 deletions)

View changed files

📝 dependencies.sh (+4 -4)
📝 mooncake-store/tests/CMakeLists.txt (+1 -0)
➕ mooncake-store/tests/ipv6_client_test.cpp (+414 -0)
📝 mooncake-transfer-engine/include/common.h (+90 -26)

📄 Description

Description

This PR fixes the IPv6 link-local address support issue reported in #1043. The problem was that IPv6 link-local addresses (e.g., fe80::xxx%interface) could not be properly parsed and used for RPC connections.

Testing

add test: ipv6_client_test
Link-local test with environment variable:
MC_USE_IPV6=1 SERVER_ADDRESS_LL="[fe80::xxx:xxx:xxx:xxx%eno2]:17813"
./build/mooncake-store/tests/ipv6_client_test
--gtest_filter="IPv6ClientTest.BasicPutGetOverLinkLocalIPv6"
[ PASSED ] 1 test.
Verified mooncake_master can listen on link-local address using netstat -lnp

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1137 **Author:** [@Azure-Tang](https://github.com/Azure-Tang) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `update-ylt` --- ### 📝 Commits (4) - [`9db2919`](https://github.com/kvcache-ai/Mooncake/commit/9db29191cd310f31bb6133422f36be147211a4cd) update yanlanting dependency - [`aa7949c`](https://github.com/kvcache-ai/Mooncake/commit/aa7949c495e50d0ec8c80a32d6dc3ba36e7cd1dd) [TE] Fix IPv6 link-local address parsing and add IPv6 tests - [`d4f3868`](https://github.com/kvcache-ai/Mooncake/commit/d4f3868a4c229ce9fd4605d4777238f7b6697d8c) [Store] Address PR review feedback for IPv6 support - [`d41cfa3`](https://github.com/kvcache-ai/Mooncake/commit/d41cfa30b590ed7293293db37174cb617a034776) format code ### 📊 Changes **4 files changed** (+509 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `dependencies.sh` (+4 -4) 📝 `mooncake-store/tests/CMakeLists.txt` (+1 -0) ➕ `mooncake-store/tests/ipv6_client_test.cpp` (+414 -0) 📝 `mooncake-transfer-engine/include/common.h` (+90 -26) </details> ### 📄 Description ## Description This PR fixes the IPv6 link-local address support issue reported in #1043. The problem was that IPv6 link-local addresses (e.g., fe80::xxx%interface) could not be properly parsed and used for RPC connections. ## Testing * add test: `ipv6_client_test` Link-local test with environment variable: MC_USE_IPV6=1 SERVER_ADDRESS_LL="[fe80::xxx:xxx:xxx:xxx%eno2]:17813" \ ./build/mooncake-store/tests/ipv6_client_test \ --gtest_filter="IPv6ClientTest.BasicPutGetOverLinkLocalIPv6" [ PASSED ] 1 test. * Verified mooncake_master can listen on link-local address using netstat -lnp ## Type of Change * Types - [x] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [x] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1137] [MERGED] [store] Fix IPv6 link-local address parsing and add IPv6 tests #2036