mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #4011] [Bug] Recorded-crash debugger cleanup rejects its owned GDB after launcher exec #1596
Closed
opened 2026-10-16 21:07:40 +00:00 by bsakaguchi
·
4 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#1596
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 15, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/4011
Before submitting
Area
Native analysis or decompilation
Observed behavior
Source-derived defect, supported by an executed simulated-provider test: the optional recorded-crash debugger stage starts Python, deliberately execs GDB, then rejects that correctly owned live process during cancellation because ownership still expects Python. The simulated production-setting case returned
ProviderAdapterErrorwithcleanupIncomplete: true, reportedowned launcher command identity did not match, and sent no stop signal. A control that removed only the stale command expectation stopped the same simulated process and returned ordinaryAnalysisCancelledError.No real Python core decoder, GDB or pwndbg process was launched. A public CLI/MCP runtime reproduction was not run.
Reproduction
The executed focused test called the real
RecordedCrashService,PwntoolsRecordedCrashProvider,inspectPwndbgCore, supervisor and ownership cleanup. It injected a valid source-owned core fixture reply, then a launcher/process table with the configured debugger command, matching parent, process group and run token. The test selected Linux x64 host fields inside the isolated test and restored them afterward. Both cases passed as assertions of the defect and its discriminating control.With the baseline checkout and locked dependencies prepared, save this test as
tests/process-global/recordedCrashDebuggerCancellation.test.tsand run:Executed production-boundary test
The test retires the fake debugger before teardown. The production trigger established by source, but not executed here, is
node scripts/rea.mjs inspect-recorded-crash CORE --debugger-context --jsonon the documented Linux host with configured engine paths and a valid supported core, followed by cancellation while GDB remains live after exec.Expected behavior
Optional debugger mapping context documents that the owned Python launcher replaces itself with GDB and that the outer provider owns both processes. Bounds and verification makes cancellation and independent owned cleanup explicit. Cleanup must recognize the configured debugger after deliberate exec and retire it on cancellation while preserving parent, process-group and run-token validation.
Impact and scope
The defect affects cancellation during optional debugger enrichment while the owned debugger remains live. The simulation proves the ownership mismatch and missed signal, but does not establish real-engine persistence duration, resource use or occurrence frequency. Waiting for natural debugger exit is an unverified workaround. Omitting debugger context avoids the stage but does not preserve the requested optional result.
REA version
rea 6.5.0 at source commit
4692bb3330; unchanged failing code checked by source at origin/main6fcfc5b5e0Runtime and platform
Node 24.18.0; macOS arm64; Vitest 5.0.3. Test used a simulated launcher/process table and selected Linux x64 fields. The documented production context is Linux x64 with the configured pwntools profile and optional GDB/pwndbg.
Target and artifact context
Source-owned recorded-crash fixture with simulated decoder output and debugger process identity. No real core decoder or debugger engine was exercised.
Interface
Other
Earliest failure stage
Cleanup, cancellation, or lifecycle
Relevant output or evidence
Meaningful output from both executed simulated-provider cases:
relaxCommand=falsepreserves production ownership settings. The control changes only the obsolete expected-command setting for the optional debugger stage; matching parent, process-group and run-token checks remain enabled.Source reachability:
src/cli/binaryDiagnosticsCommands.tsandsrc/composition/binaryDiagnostics.tsreachRecordedCrashService.inspectAndClose,PwntoolsDecoder.#inspect, andPwntoolsRecordedCrashProvider'sinclude_debugger_contextbranch. The MCP contract is registered insrc/server/registerRecordedCrashTools.ts. After host, regular core, size/profile and basic decoder admission, absolute readable plugin/venv paths and executable GDB reachinspectPwndbgCore.All cited failing source files and the recorded-crash documentation are unchanged between the baseline and current origin/main revision above. This was a source freshness check, not a new runtime execution.
Typed outcome or recovery expected
Cancellation should stop the admitted, correctly owned debugger and retain cancellation as the primary result with completed cleanup. Proposed restoration checks should preserve recorded evidence and permit runtime-root retirement, with wrong-parent, wrong-group and wrong-token controls. A real Linux GDB/pwndbg cancellation run would additionally establish engine timing and process-table presentation.
Analysis or suspected cause
Source-derived chain:
src/native/pwndbg/PwndbgCoreContext.ts:148-174constructs the Python spawn without an exec-aware command expectation.bridge/pwndbg/launch_impl.py:26callsos.execvewith the configured GDB.src/process/ProviderProcess.ts:259-261defaults the ownership command to the original Python executable.src/process/ProcessOwnershipIdentity.ts:19-23rejects that changed command.settleLauncherExitinsrc/process/ProcessOwnership.tsretains the rejection when a refreshed process table still contains the debugger, before signaling.The basic decoder separately uses
expectedCommand: nullinsrc/native/pwntools/PwntoolsDecoder.ts:304to accommodate launcher exec transitions. That setting does not propagate to the independently constructed optional stage.Additional context
Closed #3337 reports a related ownership-command mismatch for Apktool shell launchers. This report concerns the separate recorded-crash optional debugger spawn and its deliberate Python-to-GDB exec; that path still retains Python as its expected command on current main. Open PR #1959 adds shared debugger session shutdown helpers and does not modify this optional stage or its command identity. No last known good version is established.
@XinwangTao commented on GitHub (Oct 15, 2026):
The ownership model breaks exactly where the launcher stops being itself: the stage deliberately execs GDB, so the cleanup path comparing against the stale Python command identity is validating the wrong process. Since the mapping context already documents that the provider owns both the launcher and the replaced debugger, the fix should update the ownership identity at exec time (or let cleanup match the configured debugger command), so cancellation can retire the live GDB and send the stop signal, preserving parent/process-group/run-token checks. The control removing only the stale expectation is good evidence the mismatch is the sole blocker.
@yankikucuk commented on GitHub (Oct 15, 2026):
Working on this. Reproduced with your production-boundary test: cancellation during the debugger stage reported cleanup_incomplete with the command-identity mismatch and sent no signal. The debugger spawn now disables the command expectation across the launcher's exec (the basic decoder stage already does this), while parent, process-group and run-token ownership still gate the stop; the regression stops the live debugger with one SIGKILL and returns a plain cancellation, and a foreign-parent control is still refused. No real GDB was run. Draft PR follows shortly.
@XinwangTao commented on GitHub (Oct 16, 2026):
yankikucuk, disabling the command expectation across the launcher's exec matches the ownership reality — the stage process becomes GDB, so identity must follow the exec, while keeping parent/process-group/run-token checks as the stop gates preserves the safety model. The foreign-parent control staying refused is a good sign the fix is scoped correctly.
@N0zoM1z0 commented on GitHub (Oct 16, 2026):
Confirmed the reported ownership mismatch on current Linux main (
d72d856f5) with real GNU GDB 13.1 and pwndbg 2026.09.15, and opened #4435.The fault probe loads the unchanged vendor entry through an authored initialization wrapper, pauses after Python has exec'd into native GDB, then cancels through the production recorded-crash adapter. The same recorded core (SHA-256
2a30f61376c50185308ccf899111d5b26e5f75da06e43da38a0dbf473997ccc8) was used before/after:0f3bd2e3dcleanup_incompletecancelledBase's nested cleanup cause explicitly compares observed
/usr/bin/gdb …against the old Python expectation. The fix moves the exec-aware default into the shared decoder command owner, removing the basic-stage special case. Existing parent/group/run-token checks and explicit command pins remain. A real exec with a foreign token is still refused; files and retryable ownership remain retained.Validation: 100 affected tests passed (1 existing skip), type/lint and docs checks passed. The unmodified public CLI/MCP verifier passed all 42 cases on both base and head, separately from the controlled fault probe. Full-workflow timing varied (82/149 s, sampled peak RSS 2.63/2.55 GiB); repeated controls are pending, so no performance conclusion is claimed yet. Other OSes and MCP SDK raw-partial recovery after cancellation are unverified.
Part of #4227. Raw local reports and measurements:
/tmp/rea-4011-pwndbg-exec-20261016/.