[PR #212] [MERGED] fix(setup): omit aligned skill from plan #1864

New issue

Closed

opened 2026-10-16 21:11:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/212
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/setup-plan-idempotence

📝 Commits (3)

2984fa7 fix(setup): omit aligned skill from plan
a597639 test(package): cover aligned setup plan
a86da4f fix(setup): omit aligned client configurations from plan

📊 Changes

6 files changed (+211 additions, -38 deletions)

View changed files

📝 scripts/verify-package.mjs (+14 -1)
📝 src/application/Setup.ts (+122 -19)
📝 src/application/SetupPlan.ts (+11 -6)
📝 src/application/SetupSkill.ts (+36 -9)
📝 tests/setup.test.ts (+22 -2)
📝 tests/setupSkill.test.ts (+6 -1)

📄 Description

What changed

add a read-only canonical skill preflight to the setup host boundary
include install_skill only when the managed skill is missing or differs from the packaged copy
skip confirmation entirely when setup discovers no mutations
avoid invoking the skill installer when the preflight reports an aligned installation

Root cause

setupPlan had no skill-state input, so it unconditionally advertised install_skill even when installCanonicalSkill would later return unchanged. The planner therefore could not truthfully describe its mutation set before approval.

Impact

Idempotent rea setup runs no longer claim a managed-skill write or require approval when the complete plan is empty.

Closes #168.

Verification

npm run typecheck
npx oxlint src/application/Setup.ts src/application/SetupPlan.ts src/application/SetupSkill.ts tests/setup.test.ts tests/setupSkill.test.ts
npx vitest run tests/setup.test.ts tests/setupSkill.test.ts --coverage.enabled=false --retry=0 (19 tests)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/212 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/setup-plan-idempotence` --- ### 📝 Commits (3) - [`2984fa7`](https://github.com/morluto/rea/commit/2984fa74acfb6f7cbb504677a348e20bff85b806) fix(setup): omit aligned skill from plan - [`a597639`](https://github.com/morluto/rea/commit/a5976396eb424933232844e161cdab84b452b361) test(package): cover aligned setup plan - [`a86da4f`](https://github.com/morluto/rea/commit/a86da4ff3f9279e4ca3fc792e6f18542fee9e0ce) fix(setup): omit aligned client configurations from plan ### 📊 Changes **6 files changed** (+211 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify-package.mjs` (+14 -1) 📝 `src/application/Setup.ts` (+122 -19) 📝 `src/application/SetupPlan.ts` (+11 -6) 📝 `src/application/SetupSkill.ts` (+36 -9) 📝 `tests/setup.test.ts` (+22 -2) 📝 `tests/setupSkill.test.ts` (+6 -1) </details> ### 📄 Description ## What changed - add a read-only canonical skill preflight to the setup host boundary - include `install_skill` only when the managed skill is missing or differs from the packaged copy - skip confirmation entirely when setup discovers no mutations - avoid invoking the skill installer when the preflight reports an aligned installation ## Root cause `setupPlan` had no skill-state input, so it unconditionally advertised `install_skill` even when `installCanonicalSkill` would later return `unchanged`. The planner therefore could not truthfully describe its mutation set before approval. ## Impact Idempotent `rea setup` runs no longer claim a managed-skill write or require approval when the complete plan is empty. Closes #168. ## Verification - `npm run typecheck` - `npx oxlint src/application/Setup.ts src/application/SetupPlan.ts src/application/SetupSkill.ts tests/setup.test.ts tests/setupSkill.test.ts` - `npx vitest run tests/setup.test.ts tests/setupSkill.test.ts --coverage.enabled=false --retry=0` (19 tests) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:54 +00:00