[PR #215] [MERGED] fix(setup): configure every detected client #1865

New issue

Closed

opened 2026-10-16 21:11:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/215
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/setup-all-clients

📝 Commits (2)

24f9a1f fix(setup): configure every detected client
8f73112 test(setup): cover later clients after failure

📊 Changes

3 files changed (+42 additions, -8 deletions)

View changed files

📝 scripts/verify-package.mjs (+12 -4)
📝 src/application/SetupClients.ts (+5 -4)
📝 tests/setup.test.ts (+25 -0)

📄 Description

Summary

continue setup across every detected client after an earlier client transaction fails
retain each client’s truthful outcome and every successfully applied action
preserve the first actionable remediation while avoiding hidden partial configuration

The root cause was an early return inside the client loop, which made later detected clients invisible and left setup results incomplete.

Closes #145

Verification

npm run typecheck
npm run lint (existing warnings only)
npm run format:check
affected setup/runtime/reference suite: 34 tests passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/215 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/setup-all-clients` --- ### 📝 Commits (2) - [`24f9a1f`](https://github.com/morluto/rea/commit/24f9a1ff11e4d1a6361071739fa937d88159fb33) fix(setup): configure every detected client - [`8f73112`](https://github.com/morluto/rea/commit/8f7311285b2ba7a1ed427d61e437dd2665e20d12) test(setup): cover later clients after failure ### 📊 Changes **3 files changed** (+42 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify-package.mjs` (+12 -4) 📝 `src/application/SetupClients.ts` (+5 -4) 📝 `tests/setup.test.ts` (+25 -0) </details> ### 📄 Description ## Summary - continue setup across every detected client after an earlier client transaction fails - retain each client’s truthful outcome and every successfully applied action - preserve the first actionable remediation while avoiding hidden partial configuration The root cause was an early return inside the client loop, which made later detected clients invisible and left setup results incomplete. Closes #145 ## Verification - `npm run typecheck` - `npm run lint` (existing warnings only) - `npm run format:check` - affected setup/runtime/reference suite: 34 tests passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:57 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:56:09 +00:00

[PR #1865] [MERGED] fix(artifacts): preserve physical ZIP member identities #4861

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1865

No description provided.

Rows
Columns