[PR #231] [MERGED] fix(tooling): isolate concurrent repository checks #1882

Closed
opened 2026-10-16 21:12:07 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/231
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/tooling-isolation


📝 Commits (1)

  • ab8c5c1 fix(tooling): isolate concurrent repository checks

📊 Changes

2 files changed (+15 additions, -14 deletions)

View changed files

📝 scripts/scan-todos.mjs (+8 -14)
📝 vitest.config.ts (+7 -0)

📄 Description

Summary

  • give every Vitest process its own temporary coverage report directory
  • use Node's native globSync option names in the TODO scanner
  • keep third-party node_modules trees excluded without relying on npm-glob-only options

Root causes

Vitest coverage cleanup uses its configured reports directory. Concurrent test processes were deleting the same scratch files, producing intermittent .tmp rename/open failures.

The TODO scanner imports globSync from node:fs, but passed ignore and nodir, which are options from the separate npm glob package. Native globSync uses exclude.

Verification

  • two simultaneous coverage-enabled Vitest runs completed successfully
  • npm run scan:todos
  • npm run typecheck
  • focused oxlint
  • focused Prettier check
  • git diff --check

Fixes #150.
Fixes #167.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/231 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/tooling-isolation` --- ### 📝 Commits (1) - [`ab8c5c1`](https://github.com/morluto/rea/commit/ab8c5c1e13041690e07896f2f2f0dfa2134ad97e) fix(tooling): isolate concurrent repository checks ### 📊 Changes **2 files changed** (+15 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `scripts/scan-todos.mjs` (+8 -14) 📝 `vitest.config.ts` (+7 -0) </details> ### 📄 Description ## Summary - give every Vitest process its own temporary coverage report directory - use Node's native `globSync` option names in the TODO scanner - keep third-party `node_modules` trees excluded without relying on npm-glob-only options ## Root causes Vitest coverage cleanup uses its configured reports directory. Concurrent test processes were deleting the same scratch files, producing intermittent `.tmp` rename/open failures. The TODO scanner imports `globSync` from `node:fs`, but passed `ignore` and `nodir`, which are options from the separate npm `glob` package. Native `globSync` uses `exclude`. ## Verification - two simultaneous coverage-enabled Vitest runs completed successfully - `npm run scan:todos` - `npm run typecheck` - focused oxlint - focused Prettier check - `git diff --check` Fixes #150. Fixes #167. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-16 21:12:07 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#1882
No description provided.