[PR #507] [MERGED] fix(javascript): avoid invented computed destructuring properties #2033

New issue

Closed

opened 2026-10-16 21:13:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/507
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/computed-destructuring-20261004

📝 Commits (1)

e079331 fix(javascript): avoid invented computed destructuring properties

📊 Changes

3 files changed (+46 additions, -2 deletions)

View changed files

📝 src/application/JavaScriptSemanticGraphResources.test.ts (+18 -0)
📝 src/domain/javascriptSemanticAnalysis.dataflow.test.ts (+26 -0)
📝 src/domain/javascriptSemanticObjects.ts (+2 -2)

📄 Description

Change

Use the existing computed-aware static-name helper for destructuring. Dynamic [key] no longer creates a resolved key property-slot/destructures edge; literal computed keys, aliases and shorthand are preserved. Native public analyzer and graph projection controls, no module mocks.

Reproduction and verification

17 tests PASS; before2FAIL15PASS

npm run check:pr: passed (Test Files 352 passed (352); Tests 1800 passed | 2 skipped (1802)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/507 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/computed-destructuring-20261004` --- ### 📝 Commits (1) - [`e079331`](https://github.com/morluto/rea/commit/e0793312335eea9907ff9c316f56e52700a6be4a) fix(javascript): avoid invented computed destructuring properties ### 📊 Changes **3 files changed** (+46 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/application/JavaScriptSemanticGraphResources.test.ts` (+18 -0) 📝 `src/domain/javascriptSemanticAnalysis.dataflow.test.ts` (+26 -0) 📝 `src/domain/javascriptSemanticObjects.ts` (+2 -2) </details> ### 📄 Description ## Change Use the existing computed-aware static-name helper for destructuring. Dynamic [key] no longer creates a resolved key property-slot/destructures edge; literal computed keys, aliases and shorthand are preserved. Native public analyzer and graph projection controls, no module mocks. ## Reproduction and verification 17 tests PASS; before2FAIL15PASS - `npm run check:pr`: passed (Test Files 352 passed (352); Tests 1800 passed | 2 skipped (1802)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:33 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:57:37 +00:00

[PR #2033] [CLOSED] test(sourcemap): verify null embedded content through CLI and MCP #4978

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2033

No description provided.

Rows
Columns