[PR #508] [MERGED] fix(javascript): retain property reads during updates #2034

New issue

Closed

opened 2026-10-16 21:13:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/508
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/property-read-modify-write-20261004

📝 Commits (2)

4cfcc1c fix(javascript): retain property reads during updates
09238f6 Merge origin/main into fix/property-read-modify-write-20261004

📊 Changes

3 files changed (+56 additions, -0 deletions)

View changed files

📝 src/application/JavaScriptSemanticGraphResources.test.ts (+12 -0)
📝 src/domain/javascriptSemanticAnalysis.dataflow.test.ts (+28 -0)
📝 src/domain/javascriptSemanticObjects.ts (+16 -0)

📄 Description

Change

Record both reads-property and writes-property dependencies for updates and compound/logical assignments. Plain assignment stays write-only; plain member access stays read-only. Actual source analyzer and graph native tests, no runtime execution claim.

Reproduction and verification

24 tests PASS; before8FAIL16PASS

npm run check:pr: passed (Test Files 352 passed (352); Tests 1807 passed | 2 skipped (1809)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/508 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/property-read-modify-write-20261004` --- ### 📝 Commits (2) - [`4cfcc1c`](https://github.com/morluto/rea/commit/4cfcc1cfb81314319694f50ed975fde17dcb4c92) fix(javascript): retain property reads during updates - [`09238f6`](https://github.com/morluto/rea/commit/09238f6cf888f1c7d662469f7532acdacefb8e61) Merge origin/main into fix/property-read-modify-write-20261004 ### 📊 Changes **3 files changed** (+56 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/application/JavaScriptSemanticGraphResources.test.ts` (+12 -0) 📝 `src/domain/javascriptSemanticAnalysis.dataflow.test.ts` (+28 -0) 📝 `src/domain/javascriptSemanticObjects.ts` (+16 -0) </details> ### 📄 Description ## Change Record both reads-property and writes-property dependencies for updates and compound/logical assignments. Plain assignment stays write-only; plain member access stays read-only. Actual source analyzer and graph native tests, no runtime execution claim. ## Reproduction and verification 24 tests PASS; before8FAIL16PASS - `npm run check:pr`: passed (Test Files 352 passed (352); Tests 1807 passed | 2 skipped (1809)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:33 +00:00