[PR #773] [MERGED] fix(cli): honor the selected native plist path #2232

New issue

Closed

opened 2026-10-16 21:16:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/773
Author: @rudycelekli
Created: 10/6/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: fix/rea-inspect-plist-selected-path-20261006

📝 Commits (2)

d04a8c8 fix(cli): honor the selected native plist path
9823964 ci: run native plist selection regressions on macOS

📊 Changes

3 files changed (+67 additions, -1 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -0)
📝 src/cli/utilityCommands.ts (+1 -1)
➕ tests/boundary/cli/nativePlistCli.test.ts (+64 -0)

📄 Description

Summary

Forward inspect-plist's existing --relative-path option as path, matching the native provider and public operation contract. The wrong relative_path key was ignored, so alternate and even missing requested plists silently returned default Info.plist.

Native verification

Signed DCO head d04a8c817630c7cdc248e130c38ee6394ab17d95 tested on release main 9622b4b4cf0b2eb92305afd52fd67e932d57c753. At initial publication, main 554e9b1612f7799c2bc7177eb1a9b04a0f27d2e9 only reorganized README, with no production, test, dependency or policy overlap. Fresh complete authored feedback and all 16 open PR file inventories have no overlap or actionable feedback for these files; unrelated hosted cancellations are tracked separately.

Actual benign Clang app executable and native-plutil-linted plists with distinct identifiers reproduce the public CLI failure. Requested Alternate.plist reads Info.plist; requested Missing.plist also succeeds reading Info.plist. Default selection is a passing control.
Focused baseline: two actual compiled CLI failures, one control passes. Final focused: 18 tests pass (3 actual native CLI cases plus 15 existing native provider tests using their recording seams).
Actual compiled CLI selected paths/values match independent native plutil and a separate real SDK stdio MCP session using inspect_plist's existing path parameter. Missing requested files fail through both adapters.
npm run check: all five tasks pass, 125 existing warnings and zero errors; none concern the changed files. check:fast, build:cached, SSH signature/DCO and diff checks pass.

No new option, grammar, schema, provider or packaging behavior. Native macOS plist selection only; no Hopper, Ghidra, IDA, GUI, Windows or target execution claim. Hosted checks are recorded separately.

AI-assisted implementation and independent source review. Fixes #772.

macOS CI regression coverage

Signed DCO maintenance head 9823964199f628e616f60cf5d66049e262815d67 explicitly runs the existing three-case regression in the apple-artifacts job on macos-14:

npm run test:focused -- tests/boundary/cli/nativePlistCli.test.ts

The exact local command passes default, alternate and missing plist selection cases. Required check passes all five tasks and the actual pre-push check:fast passes both tasks. Updated hosted checks are pending; the prior green run did not execute these darwin-gated cases on the Linux test shards.

Hosted macOS update: the new native regression step has completed successfully and the job log reports all three native plist cases passed: https://github.com/morluto/rea/actions/runs/37513933495/job/112441974491. This verifies the updated step itself; remaining hosted contexts are audited separately.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/773 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/6/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/rea-inspect-plist-selected-path-20261006` --- ### 📝 Commits (2) - [`d04a8c8`](https://github.com/morluto/rea/commit/d04a8c817630c7cdc248e130c38ee6394ab17d95) fix(cli): honor the selected native plist path - [`9823964`](https://github.com/morluto/rea/commit/9823964199f628e616f60cf5d66049e262815d67) ci: run native plist selection regressions on macOS ### 📊 Changes **3 files changed** (+67 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -0) 📝 `src/cli/utilityCommands.ts` (+1 -1) ➕ `tests/boundary/cli/nativePlistCli.test.ts` (+64 -0) </details> ### 📄 Description ## Summary Forward inspect-plist's existing --relative-path option as `path`, matching the native provider and public operation contract. The wrong `relative_path` key was ignored, so alternate and even missing requested plists silently returned default Info.plist. ## Native verification Signed DCO head `d04a8c817630c7cdc248e130c38ee6394ab17d95` tested on release main `9622b4b4cf0b2eb92305afd52fd67e932d57c753`. At initial publication, main `554e9b1612f7799c2bc7177eb1a9b04a0f27d2e9` only reorganized README, with no production, test, dependency or policy overlap. Fresh complete authored feedback and all 16 open PR file inventories have no overlap or actionable feedback for these files; unrelated hosted cancellations are tracked separately. - Actual benign Clang app executable and native-plutil-linted plists with distinct identifiers reproduce the public CLI failure. Requested Alternate.plist reads Info.plist; requested Missing.plist also succeeds reading Info.plist. Default selection is a passing control. - Focused baseline: two actual compiled CLI failures, one control passes. Final focused: 18 tests pass (3 actual native CLI cases plus 15 existing native provider tests using their recording seams). - Actual compiled CLI selected paths/values match independent native plutil and a separate real SDK stdio MCP session using inspect_plist's existing `path` parameter. Missing requested files fail through both adapters. - `npm run check`: all five tasks pass, 125 existing warnings and zero errors; none concern the changed files. `check:fast`, `build:cached`, SSH signature/DCO and diff checks pass. No new option, grammar, schema, provider or packaging behavior. Native macOS plist selection only; no Hopper, Ghidra, IDA, GUI, Windows or target execution claim. Hosted checks are recorded separately. AI-assisted implementation and independent source review. Fixes #772. ## macOS CI regression coverage Signed DCO maintenance head `9823964199f628e616f60cf5d66049e262815d67` explicitly runs the existing three-case regression in the `apple-artifacts` job on `macos-14`: ```sh npm run test:focused -- tests/boundary/cli/nativePlistCli.test.ts ``` The exact local command passes default, alternate and missing plist selection cases. Required `check` passes all five tasks and the actual pre-push `check:fast` passes both tasks. Updated hosted checks are pending; the prior green run did not execute these darwin-gated cases on the Linux test shards. Hosted macOS update: the new native regression step has completed successfully and the job log reports all three native plist cases passed: https://github.com/morluto/rea/actions/runs/37513933495/job/112441974491. This verifies the updated step itself; remaining hosted contexts are audited separately. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:01 +00:00