[PR #2232] [MERGED] fix(process): report single empty settlement observation as unverifiable #5100

New issue

Closed

opened 2026-10-31 01:03:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:03:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2232
Author: @sx4im
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @morluto

Base: main ← Head: fix/settlement-single-empty-observation

📝 Commits (1)

019fe4d fix(process): report single empty settlement observation as unverifiable

📊 Changes

2 files changed (+83 additions, -2 deletions)

View changed files

📝 src/process/capture/ProcessCaptureLifecycle.ts (+10 -2)
➕ tests/boundary/process/processSettlementDeadline.test.ts (+73 -0)

📄 Description

Summary

observeSettlement reported alive_at_deadline when the settlement budget expired after a single empty observation, even though no live member was ever observed. An empty observation leaves quiescence uncertain; it is not evidence the group was alive.

Fixes #2170.

Change

In src/process/capture/ProcessCaptureLifecycle.ts, track whether any settlement round observed a live member. The deadline fall-through now returns alive_at_deadline only when liveness was actually observed, and unverifiable otherwise. The two-consecutive-empty-observations rule for quiesced is unchanged. The cleanup_outcome projection for non-quiesced settlements stays cleaned; cleanup itself is untouched.

Verification

New tests/boundary/process/processSettlementDeadline.test.ts (3 tests, red-green verified):

single empty observation at deadline → unverifiable (failed before the fix with alive_at_deadline)
genuinely live owned group at deadline → still alive_at_deadline
two consecutive empty observations → still quiesced

npm run check:fast (typecheck + lint): green.
npm run verify:test-discovery: all 934 test files discovered exactly once.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2232 **Author:** [@sx4im](https://github.com/sx4im) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/12/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/settlement-single-empty-observation` --- ### 📝 Commits (1) - [`019fe4d`](https://github.com/morluto/rea/commit/019fe4d82e73e929da206443e52f26c5b8426089) fix(process): report single empty settlement observation as unverifiable ### 📊 Changes **2 files changed** (+83 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/process/capture/ProcessCaptureLifecycle.ts` (+10 -2) ➕ `tests/boundary/process/processSettlementDeadline.test.ts` (+73 -0) </details> ### 📄 Description ## Summary `observeSettlement` reported `alive_at_deadline` when the settlement budget expired after a single empty observation, even though no live member was ever observed. An empty observation leaves quiescence uncertain; it is not evidence the group was alive. Fixes #2170. ## Change In `src/process/capture/ProcessCaptureLifecycle.ts`, track whether any settlement round observed a live member. The deadline fall-through now returns `alive_at_deadline` only when liveness was actually observed, and `unverifiable` otherwise. The two-consecutive-empty-observations rule for `quiesced` is unchanged. The `cleanup_outcome` projection for non-quiesced settlements stays `cleaned`; cleanup itself is untouched. ## Verification New `tests/boundary/process/processSettlementDeadline.test.ts` (3 tests, red-green verified): - single empty observation at deadline → `unverifiable` (failed before the fix with `alive_at_deadline`) - genuinely live owned group at deadline → still `alive_at_deadline` - two consecutive empty observations → still `quiesced` `npm run check:fast` (typecheck + lint): green. `npm run verify:test-discovery`: all 934 test files discovered exactly once. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:03:55 +00:00