[PR #803] [CLOSED] fix(native): preserve exact code signing identifiers #2250

New issue

Closed

opened 2026-10-16 21:16:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/803
Author: @rudycelekli
Created: 10/6/2026
Status: ❌ Closed

Base: main ← Head: fix/codesign-exact-identifier-20261006

📝 Commits (1)

0557792 fix(native): preserve exact code signing identifiers

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 src/native/parsers/codesign.ts (+2 -1)
📝 tests/boundary/providers/native/nativeProvider.test.ts (+13 -0)

📄 Description

Summary

Preserve the exact Identifier= value emitted by codesign -d --verbose=4. Signing identifiers can contain leading or trailing spaces; trimming the value changes the inspected identity. Other display-field normalization is unchanged.

Verification

Actual owned native workflow: compile a small Mach-O with host Clang, ad-hoc sign it with /usr/bin/codesign, resolve it through parseBinaryTarget, and call the public NativeMacOSProvider inspect_signature operation. Three spaced identifiers mismatch on main; all four identifiers (including the ordinary control) match after this fix.
npm run test:focused -- tests/boundary/providers/native/nativeProvider.test.ts tests/boundary/providers/native/nativeInventory.golden.test.ts: 25 passed.
npm run check: all five tasks passed; 129 existing lint warnings, zero errors.
npm run check:fast: passed.

Native proof ran on macOS arm64 with the installed Apple toolchain. No other OS matrix or credentialed signing is claimed. No Hopper/Ghidra behavior changes; those real-provider workflows were not run. Hosted CI will run separately.

AI assistance was used for investigation, implementation, and regression tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/803 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/6/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/codesign-exact-identifier-20261006` --- ### 📝 Commits (1) - [`0557792`](https://github.com/morluto/rea/commit/0557792049e136ba31726f0736b22af62288e46d) fix(native): preserve exact code signing identifiers ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/native/parsers/codesign.ts` (+2 -1) 📝 `tests/boundary/providers/native/nativeProvider.test.ts` (+13 -0) </details> ### 📄 Description ## Summary Preserve the exact `Identifier=` value emitted by `codesign -d --verbose=4`. Signing identifiers can contain leading or trailing spaces; trimming the value changes the inspected identity. Other display-field normalization is unchanged. ## Verification - Actual owned native workflow: compile a small Mach-O with host Clang, ad-hoc sign it with `/usr/bin/codesign`, resolve it through `parseBinaryTarget`, and call the public `NativeMacOSProvider` `inspect_signature` operation. Three spaced identifiers mismatch on main; all four identifiers (including the ordinary control) match after this fix. - `npm run test:focused -- tests/boundary/providers/native/nativeProvider.test.ts tests/boundary/providers/native/nativeInventory.golden.test.ts`: 25 passed. - `npm run check`: all five tasks passed; 129 existing lint warnings, zero errors. - `npm run check:fast`: passed. Native proof ran on macOS arm64 with the installed Apple toolchain. No other OS matrix or credentialed signing is claimed. No Hopper/Ghidra behavior changes; those real-provider workflows were not run. Hosted CI will run separately. AI assistance was used for investigation, implementation, and regression tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:17 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:04:06 +00:00

[PR #2250] [MERGED] fix(website): prioritize getting started across language editions #5118

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2250

No description provided.

Rows
Columns